Paths

Table of Contentst

Differential D8962

[backup] Update `BlobItem`
ClosedPublic
Actions

Authored by michal on Aug 28 2023, 12:57 AM.

Tags

None

Referenced Files

	F2836542: D8962.id30419.diff
	Sat, Sep 28, 4:48 PM

	F2831490: D8962.id30529.diff
	Fri, Sep 27, 11:58 PM

	F2831489: D8962.id30419.diff
	Fri, Sep 27, 11:58 PM

	F2831433: D8962.id.diff
	Fri, Sep 27, 11:57 PM

	F2831386: D8962.diff
	Fri, Sep 27, 11:49 PM

	Unknown Object (File)
	Sat, Sep 14, 3:06 PM

	Unknown Object (File)
	Tue, Sep 10, 6:26 PM

	Unknown Object (File)
	Aug 29 2024, 1:31 PM

View All 93 Files

Subscribers

Details

Reviewers

bartek
• patryk
kamil
• jon

Commits

rCOMM3c1ce0afaf0f: [backup] Update `BlobItem`

Summary

Modernize BlobItem and update it to match new database design.

Depends on D8954

Test Plan

cargo check, tested with the rest of the stack

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 28 2023, 12:57 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 12:57 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B22154: Diff 30419.Aug 28 2023, 1:14 AM

michal requested review of this revision.Aug 28 2023, 1:14 AM

michal added a child revision: D8963: [backup] Introduce upload endpoint.Aug 28 2023, 1:33 AM

bartek accepted this revision.Aug 28 2023, 5:00 AM

bartek added inline comments.

services/backup/src/constants.rs
17–24 ↗	(On Diff #30419)	Nit/followup: You're right that it would be nice to add a submodule for table constants: `constants::backup_table::FIELD_XYZ`

This revision is now accepted and ready to land.Aug 28 2023, 5:00 AM

michal added inline comments.Aug 29 2023, 10:55 AM

services/backup/src/constants.rs
17–24 ↗	(On Diff #30419)	Probably gonna do a separate diff with both backup and log constants

Closed by commit rCOMM3c1ce0afaf0f: [backup] Update `BlobItem` (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM3c1ce0afaf0f: [backup] Update `BlobItem`.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

4 lines

database/

147 lines

37 lines

comm-services-lib/

src/

22 lines

Diff 30529

services/backup/src/constants.rs

Loading...

services/backup/src/database/backup_item.rs

Loading...

services/backup/src/database/mod.rs

Loading...

services/comm-services-lib/src/database.rs

Loading...