[native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`
ClosedPublic
Actions

Authored by atul on Sep 14 2023, 1:31 PM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM07a97b02cad6: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`

Summary

One more step in decoupling search from ChatThreadList.

Depends on D9206

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 14 2023, 1:31 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 1:31 PM

atul published this revision for review.Sep 14 2023, 1:40 PM

atul added a child revision: D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.Sep 14 2023, 1:41 PM

Harbormaster completed remote builds in B22641: Diff 31152.Sep 14 2023, 1:48 PM

tomek accepted this revision.Sep 18 2023, 3:51 AM

tomek added inline comments.

native/chat/chat-thread-list.react.js
475–481	This effect was always rendered and was working even if `renderSearch` wasn't called. Now, after it is moved to `ChatThreadListSearch` it is rendered only when this component is present. Can it cause any issues?

This revision is now accepted and ready to land.Sep 18 2023, 3:51 AM

atul added inline comments.Sep 18 2023, 10:20 AM

native/chat/chat-thread-list.react.js
475–481	I think this makes more sense since `searchCancelButton` lives "within" `ChatThreadListSearch` which was formerly contained within `renderSearch`. By default the value is set to 0 so nothing should change there.