Page MenuHomePhabricator

[native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`
ClosedPublic

Authored by atul on Thu, Sep 14, 1:31 PM.
Tags
None
Referenced Files
F772742: D9207.diff
Mon, Sep 25, 2:03 AM
Unknown Object (File)
Fri, Sep 22, 4:22 PM
Subscribers

Details

Summary

One more step in decoupling search from ChatThreadList.


Depends on D9206

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Thu, Sep 14, 1:40 PM
tomek added inline comments.
native/chat/chat-thread-list.react.js
475–481 ↗(On Diff #31152)

This effect was always rendered and was working even if renderSearch wasn't called. Now, after it is moved to ChatThreadListSearch it is rendered only when this component is present. Can it cause any issues?

This revision is now accepted and ready to land.Mon, Sep 18, 3:51 AM
native/chat/chat-thread-list.react.js
475–481 ↗(On Diff #31152)

I think this makes more sense since searchCancelButton lives "within" ChatThreadListSearch which was formerly contained within renderSearch. By default the value is set to 0 so nothing should change there.