[keyserver] Delete sidebars created from pinned message robotexts
ClosedPublic
Actions

Authored by ashoat on Sep 19 2023, 1:05 PM.

Details

Reviewers

atul
rohan
inka

Commits

rCOMM44a1bbf93561: [keyserver] Delete sidebars created from pinned message robotexts

Summary

Depends on D9229

These threads are causing our keyserver to completely crash and the app to break (ENG-4849). From running the base query on my keyserver, I can see that Jacek is the only user who has threads like these.

The most immediate solution is to delete these test threads. A later diff will prevent their creation.

Test Plan

I repro'd the issue in my local environment following the steps in the linked Linear task's description. After that the web app failed to load. After applying this migration, the web app was once again able to load.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 19 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 19 2023, 1:05 PM

Rebase

Harbormaster failed remote builds in B22735: Diff 31273!Sep 19 2023, 1:19 PM

ashoat retitled this revision from [keyserver] Delete threads created from pinned message robotexts to [keyserver] Delete sidebars created from pinned message robotexts.Sep 19 2023, 1:21 PM

ashoat added a child revision: D9231: [keyserver] Move sidebar-of-sidebar check earlier in createThread.Sep 19 2023, 1:23 PM

ashoat published this revision for review.Sep 19 2023, 1:31 PM

Harbormaster completed remote builds in B22738: Diff 31276.Sep 19 2023, 1:34 PM

atul accepted this revision.Sep 19 2023, 1:38 PM

This revision is now accepted and ready to land.Sep 19 2023, 1:38 PM

Closed by commit rCOMM44a1bbf93561: [keyserver] Delete sidebars created from pinned message robotexts (authored by ashoat). · Explain WhySep 19 2023, 1:42 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM44a1bbf93561: [keyserver] Delete sidebars created from pinned message robotexts.

ashoat mentioned this in D9234: [keyserver] Skip early exit in deleteThread if ignorePermissions.Sep 19 2023, 2:30 PM

ashoat mentioned this in rCOMMd587cc151c26: [keyserver] Skip early exit in deleteThread if ignorePermissions.Sep 20 2023, 5:28 AM