These conditionals will be needed in multiple places. To preemptively prepare for this, I am factoring out these conditionals into their own variable so that we can have less redundant code
Depends on D9272
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Personally would prefer to inline these conditions but it doesn't matter a ton
| native/user-profile/user-profile-relationship-button.react.js | ||
|---|---|---|
| 88–90 | Eh I don't love the indirection here, would prefer if the conditional logic was closer to the conditional... especially when showNothing tells us nothing about the logic whereas eg showIncomingFriendRequestButtons gives us some idea of what the condition is. We could also instead have the pattern of let userProfileRelationshipButton;
if (showIncomingFriendRequestButtons) {
userProfileRelationshipButton = ...and let the null case be implicit | |
Comment Actions
Personally would prefer to inline these conditions but it doesn't matter a ton
Thought about this some more, and I agree with @atul here. This feels a bit unnecessary and will abandon this diff in favor of keeping these conditions inline