Page MenuHomePhabricator

[native] introduce UserProfileAvatar
ClosedPublic

Authored by ginsu on Oct 5 2023, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 7:35 AM
Unknown Object (File)
Oct 26 2024, 1:27 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Unknown Object (File)
Oct 20 2024, 9:29 AM
Subscribers

Details

Summary

The last part to complete the full screen user avatar view experience is to make the UserAvatar a touchable that will navigate to User Profile Avatar Modal when it gets pressed.

Initially I had all this logic living in UserProfile; however, I didn't want to overcrowd this component, so I created a separate UserProfileAvatar component to keep things better organized

This is step 5 in the list below
Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Replace out of box BottomSheetModal with basic BottomSheet (Unfortunately, BottomSheetModal does not play nice with nested navigator)
  2. Polish up the BottomSheetBackdrop animation
  3. Introduce User Profile Bottom Sheet Navigators (this is so we can navigate to User Profile Avatar Modal from the User Profile Bottom Sheet)
  4. Introduce the User Profile Avatar Modal component and all the necessary things (like route names) that we will need to navigate to this new screen
  5. Factor out the User Avatar component in UserProfile into it's own separate component to keep things better organized

Also here is a screenshot of the Figma designs for additional context:

Screenshot 2023-10-05 at 4.42.15 PM.png (1×1 px, 379 KB)

Depends on D9376

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Oct 5 2023, 1:07 PM
This revision is now accepted and ready to land.Oct 5 2023, 4:24 PM
This revision was landed with ongoing or failed builds.Oct 5 2023, 6:38 PM
This revision was automatically updated to reflect the committed changes.