Details

Reviewers

inka
kamil
atul

Commits

rCOMM1bb4d1144d4e: [keyserver] Separate webapp and keyserver endpoints

Summary

Part of ENG-5153
Depends on D9451

Finally we can split the endpoints:

webapp only hosts html, css, js and other related files
keyserver contains keyserver logic, websocket etc.

We need to add a redirect for uploads from the webapp to the keyserver because previously the urls had the origin of web.comm.app instead of squadcal.com. As mentioned in the previous diff I don't think it's worth migrating them because:

we still need to support older clients with old urls
we will be migrating to blob in the future anyway

Note: landing this diff needs to be delayed like D9291, because web clients need to be reloaded to connect to squadcal

Test Plan

check that the web and native apps still work
check that media with /webapp/ and /comm/ urls still work

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Oct 11 2023, 9:21 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 11 2023, 9:21 AM

Harbormaster completed remote builds in B23193: Diff 31941.Oct 11 2023, 9:40 AM

michal requested review of this revision.Oct 11 2023, 9:40 AM

kamil accepted this revision.Oct 16 2023, 3:54 AM

This revision is now accepted and ready to land.Oct 16 2023, 3:54 AM

michal edited the summary of this revision. (Show Details)Oct 18 2023, 3:03 AM

michal mentioned this in D9396: [keyserver] Update CORS.Oct 18 2023, 3:51 AM

Do we retire the use of the commAppRouter and squadCalRouter names in a later diff?

Rename routers

Harbormaster completed remote builds in B23375: Diff 32222.Oct 19 2023, 11:00 AM

ashoat added inline comments.Oct 19 2023, 12:00 PM

keyserver/src/keyserver.js
141 ↗	(On Diff #32222)	Should this comment be updated? `squadCalBaseRoutePath` will probably be confusing to read

Fixed remaining comment, thanks for catching that

Harbormaster completed remote builds in B23407: Diff 32275.Oct 20 2023, 9:26 AM

Setting as "plan changes" because it needs to be defered for a while to let web clients migrate (start using squadcal endpoints instead of web.comm.app).

Rebase

This revision is now accepted and ready to land.Nov 27 2023, 5:53 AM

Update for flow 202

This revision was landed with ongoing or failed builds.Nov 27 2023, 7:27 AM

Closed by commit rCOMM1bb4d1144d4e: [keyserver] Separate webapp and keyserver endpoints (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1bb4d1144d4e: [keyserver] Separate webapp and keyserver endpoints.

Harbormaster completed remote builds in B24511: Diff 33717.Nov 27 2023, 7:55 AM

Harbormaster completed remote builds in B24526: Diff 33741.Nov 27 2023, 10:42 AM