[identity] introduce new ping RPC and code version interceptor function
ClosedPublic
Actions

Authored by varun on Oct 12 2023, 10:33 PM.

Details

Reviewers

bartek
michal
• jon

Commits

rCOMM1cb3f1b36116: [identity] introduce new ping RPC and code version interceptor function

Summary

pretty straightforward... just a no-op RPC that will return an unsupported version status code if the caller's code version is outdated. will set the actual unsupported versions for each platform when we launch.

Test Plan

called the RPC from kreya with metadata to trigger both an OK response and an unsupported version response

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 12 2023, 10:33 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 10:33 PM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

varun added a child revision: D9480: [services] move eth address validation to siwe.rs.Oct 12 2023, 10:34 PM

varun added a parent revision: D9478: [shared] helper functions to get/set version unsupported status.Oct 12 2023, 10:43 PM

Harbormaster completed remote builds in B23229: Diff 31985.Oct 12 2023, 10:50 PM

varun requested review of this revision.Oct 12 2023, 10:50 PM

Accepting, but please extract that version constant.

services/identity/src/grpc_services/shared.rs
5	Minor thing but what about calling it `version_interceptor` (verb -> noun)? In our codebase it acts as an "object" passed as a kind of middleware, rather than function that is called directly.
10	const MIN_SUPPORTED_NATIVE_VERSION: u64 = 270; we should definitely extract this as a constant.
services/identity/src/main.rs
79	I'd call it this way, doesn't matter tho.
shared/protos/identity_client.proto
58–60	I assume this is deleted because it's implemented in the "authenticated service", am I right?

This revision is now accepted and ready to land.Oct 16 2023, 12:55 AM

varun added inline comments.Oct 18 2023, 7:36 PM

services/identity/src/grpc_services/shared.rs
5	yeah `interceptor` makes more sense for sure. i was just copying the pattern introduced with the `auth_intercept` function. i'll change both to `interceptor`
10	yeah makes sense
shared/protos/identity_client.proto
58–60	that's right