Page MenuHomePhabricator
Differential D9616

[lib] implement sending messages to Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Oct 27 2023, 4:37 AM.
Tags
None
Referenced Files
F3246368: D9616.id.diff
Thu, Nov 14, 11:15 PM
Unknown Object (File)
Fri, Nov 1, 6:02 AM
Unknown Object (File)
Thu, Oct 24, 8:37 AM
Unknown Object (File)
Fri, Oct 18, 9:02 PM
Unknown Object (File)
Oct 8 2024, 5:07 AM
Unknown Object (File)
Oct 2 2024, 1:07 PM
Unknown Object (File)
Oct 2 2024, 1:07 PM
Unknown Object (File)
Oct 2 2024, 1:07 PM
View All 86 Files
Subscribers
ashoat
will

Details

Reviewers
michal
bartek
tomek
Commits
rCOMM9bc16ce3b33c: [lib] implement sending messages to Tunnelbroker
Summary

Code for sending Message to another device via Tunnelbroker.

Depends on D9611

Test Plan

Test if messages are properly sent and promises are resolved/rejected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 27 2023, 4:37 AM
kamil held this revision as a draft.
Herald added subscribers: will, ashoat. · View Herald TranscriptOct 27 2023, 4:37 AM
kamil added a child revision: D9617: [web] implement screen for testing Tunnelbroker.Oct 27 2023, 4:41 AM
Harbormaster completed remote builds in B23530: Diff 32455.Oct 27 2023, 5:04 AM
kamil published this revision for review.Oct 27 2023, 5:41 AM
kamil added inline comments.
lib/tunnelbroker/tunnelbroker-context.js
112 ↗(On Diff #32455)

I'll remove this comment before landing, creating a task: ENG-5601.

kamil mentioned this in D9606: [lib] introduce Tunnelbroker Context.Oct 31 2023, 9:44 AM
michal accepted this revision.Nov 2 2023, 7:21 AM
michal added inline comments.
lib/tunnelbroker/tunnelbroker-context.js
114 ↗(On Diff #32455)

Probably testing remains?

This revision is now accepted and ready to land.Nov 2 2023, 7:21 AM
kamil updated this revision to Diff 32729.Nov 6 2023, 1:25 AM
  • remove comment
  • remove debug
lib/tunnelbroker/tunnelbroker-context.js
114 ↗(On Diff #32455)

yes, thanks

Harbormaster failed remote builds in B23767: Diff 32729!Nov 6 2023, 1:48 AM
kamil updated this revision to Diff 32733.Nov 6 2023, 2:07 AM

rebase

Harbormaster failed remote builds in B23771: Diff 32733!Nov 6 2023, 3:08 AM
Harbormaster completed remote builds in B23771: Diff 32733.Nov 6 2023, 4:18 AM
Closed by commit rCOMM9bc16ce3b33c: [lib] implement sending messages to Tunnelbroker (authored by kamil). · Explain WhyNov 6 2023, 8:30 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9bc16ce3b33c: [lib] implement sending messages to Tunnelbroker.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
54 lines

Diff 32807

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...