[Tunnelbroker] introduce function to receive message and handle `MessageToDevice` type
ClosedPublic
Actions

Authored by kamil on Oct 24 2023, 5:06 PM.

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle…

Summary

Extracting logic to function to make writing tests simpler.

Depends on D9573

Test Plan

Runn All Tunnelbroker tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 24 2023, 5:06 PM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 24 2023, 5:06 PM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

kamil added a child revision: D9575: [Tunnelbroker] add `MessageReceiveConfirmation` struct.Oct 24 2023, 5:09 PM

Harbormaster completed remote builds in B23443: Diff 32343.Oct 24 2023, 5:25 PM

kamil published this revision for review.Oct 24 2023, 6:19 PM

bartek accepted this revision.Oct 25 2023, 10:47 AM

bartek added inline comments.

services/commtest/src/tunnelbroker/socket.rs
80–87 ↗	(On Diff #32343)	Same principle as in JS ;)

This revision is now accepted and ready to land.Oct 25 2023, 10:47 AM

early exit

services/commtest/src/tunnelbroker/socket.rs
80–87 ↗	(On Diff #32343)	right! fair point

Harbormaster completed remote builds in B23596: Diff 32537.Oct 31 2023, 1:59 PM

Closed by commit rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle…. · Explain WhyNov 6 2023, 4:29 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle….

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

tunnelbroker/

socket.rs

14 lines

tests/

identity_tunnelbroker_tests.rs

21 lines

tunnelbroker_integration_tests.rs

16 lines

tunnelbroker_persist_tests.rs

26 lines

tunnelbroker_sender_confirmation_tests.rs

8 lines

tunnelbroker/

src/

websockets/

mod.rs

7 lines

Diff 32794

View Options

services/commtest/src/tunnelbroker/socket.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

View Options

services/tunnelbroker/src/websockets/mod.rs

[Tunnelbroker] introduce function to receive message and handle `MessageToDevice` typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32794

services/commtest/src/tunnelbroker/socket.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

services/commtest/tests/tunnelbroker_integration_tests.rs

services/commtest/tests/tunnelbroker_persist_tests.rs

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

services/tunnelbroker/src/websockets/mod.rs

[Tunnelbroker] introduce function to receive message and handle `MessageToDevice` type
ClosedPublic
Actions

Revision Contents
Changeset List