Page MenuHomePhabricator
Differential D9574

[Tunnelbroker] introduce function to receive message and handle `MessageToDevice` type
ClosedPublic
Actions

Authored by kamil on Oct 24 2023, 10:06 AM.
Tags
None
Referenced Files
F3251112: D9574.id32343.diff
Fri, Nov 15, 5:20 PM
Unknown Object (File)
Sat, Nov 9, 9:53 AM
Unknown Object (File)
Sat, Nov 9, 8:49 AM
Unknown Object (File)
Sat, Nov 9, 8:39 AM
Unknown Object (File)
Sat, Nov 9, 4:45 AM
Unknown Object (File)
Mon, Nov 4, 12:34 AM
Unknown Object (File)
Sun, Oct 20, 12:38 AM
Unknown Object (File)
Fri, Oct 18, 9:02 PM
View All 79 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
bartek
varun
• jon
Commits
rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle…
Summary

Extracting logic to function to make writing tests simpler.

Depends on D9573

Test Plan

Runn All Tunnelbroker tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 24 2023, 10:06 AM
kamil held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptOct 24 2023, 10:06 AM
Herald added subscribers: will, tomek, ashoat. · View Herald Transcript
kamil added a child revision: D9575: [Tunnelbroker] add `MessageReceiveConfirmation` struct.Oct 24 2023, 10:09 AM
Harbormaster completed remote builds in B23443: Diff 32343.Oct 24 2023, 10:25 AM
kamil published this revision for review.Oct 24 2023, 11:19 AM
bartek accepted this revision.Oct 25 2023, 3:47 AM
bartek added inline comments.
services/commtest/src/tunnelbroker/socket.rs
80–87 ↗(On Diff #32343)

Same principle as in JS ;)

This revision is now accepted and ready to land.Oct 25 2023, 3:47 AM
kamil updated this revision to Diff 32537.Oct 31 2023, 6:25 AM

early exit

services/commtest/src/tunnelbroker/socket.rs
80–87 ↗(On Diff #32343)

right! fair point

Harbormaster completed remote builds in B23596: Diff 32537.Oct 31 2023, 6:59 AM
Closed by commit rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle… (authored by kamil). · Explain WhyNov 6 2023, 8:29 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM05a7abc00459: [Tunnelbroker] introduce function to receive message and handle….

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
tunnelbroker/
14 lines
tests/
21 lines
16 lines
26 lines
8 lines
tunnelbroker/
src/
websockets/
7 lines

Diff 32794

View Options

services/commtest/src/tunnelbroker/socket.rs

Loading...
View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

Loading...
View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...