[native] implement screen for testing Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Oct 27 2023, 4:43 AM.

Details

Reviewers

michal
bartek
tomek
inka

Commits

rCOMM7804a3a4ba98: [native] implement screen for testing Tunnelbroker

Summary

This is a screen for testing Tunnelbroker utilities. It might be helpful for testing on production.

Styles/components are mostly copied from other places in the codebase which visually look similar. This is only for devs/staff and will be removed in the future.

Depends on D9617

Test Plan

See example here.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 27 2023, 4:43 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptOct 27 2023, 4:43 AM

Harbormaster completed remote builds in B23532: Diff 32457.Oct 27 2023, 5:29 AM

kamil published this revision for review.Oct 27 2023, 5:42 AM

kamil added a child revision: D9630: [Tunnelbroker] implement socket Heartbeats.Oct 30 2023, 7:02 AM

michal added inline comments.Nov 3 2023, 4:22 AM

native/navigation/route-names.js
112 ↗	(On Diff #32457)	Typo
native/profile/tunnelbroker-menu.react.js
27–29 ↗	(On Diff #32457)	We should cleanup listeners

address review

Harbormaster completed remote builds in B23708: Diff 32667.Nov 3 2023, 5:59 AM

michal accepted this revision.Nov 3 2023, 6:50 AM

This revision is now accepted and ready to land.Nov 3 2023, 6:50 AM

Closed by commit rCOMM7804a3a4ba98: [native] implement screen for testing Tunnelbroker (authored by kamil). · Explain WhyNov 6 2023, 8:30 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7804a3a4ba98: [native] implement screen for testing Tunnelbroker.

ashoat added inline comments.Nov 6 2023, 11:27 AM

native/profile/tunnelbroker-menu.react.js
88–92	We should avoid control flow inside JSX... same principle as "no ternary inside JSX" here: This breaks expectations around indentation usage and can hide code branches.

kamil mentioned this in D9747: [native] avoid control flow inside JSX in Tunnelbroker screen.Nov 7 2023, 6:36 AM

kamil added inline comments.Nov 7 2023, 6:37 AM

native/profile/tunnelbroker-menu.react.js
88–92	We should avoid control flow inside JSX... same principle as "no ternary inside JSX" here: This breaks expectations around indentation usage and can hide code branches. D9747