Paths

Table of Contentst

Differential D9596

[lib] define Tunnelbroker API in Flow types
ClosedPublic
Actions

Authored by kamil on Oct 25 2023, 6:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 2, 6:27 PM

	Unknown Object (File)
	Mon, Jul 1, 3:38 AM

	Unknown Object (File)
	Sun, Jun 30, 12:41 AM

	Unknown Object (File)
	Sat, Jun 29, 3:24 PM

	Unknown Object (File)
	Sat, Jun 29, 7:12 AM

	Unknown Object (File)
	Sat, Jun 29, 7:12 AM

	Unknown Object (File)
	Sat, Jun 29, 7:12 AM

	Unknown Object (File)
	Sat, Jun 29, 7:12 AM

View All 73 Files

Subscribers

Details

Reviewers

michal
bartek
varun

Commits

rCOMM972d6ddf9e0a: [lib] define Tunnelbroker API in Flow types

Summary

Adding Rust's types to JS codebase.

We have right now fragmentary types in tunnelbroker-messages.js but this file will be removed, after new shared interface will be implemented.

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 25 2023, 6:17 AM

kamil held this revision as a draft.

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 25 2023, 6:17 AM

Harbormaster completed remote builds in B23486: Diff 32394.Oct 25 2023, 6:35 AM

fix DeviceTypes

kamil added a child revision: D9606: [lib] introduce Tunnelbroker Context.Oct 26 2023, 8:50 AM

Harbormaster completed remote builds in B23510: Diff 32427.Oct 26 2023, 9:10 AM

kamil added a parent revision: D9595: [Tunnelbroker] implement sending response after session creation attempt.Oct 27 2023, 4:22 AM

kamil published this revision for review.Oct 27 2023, 5:30 AM

kamil added a child revision: D9623: [keyserver] implement socket and update code to interact with Tunnelbroker API.Oct 27 2023, 9:58 AM

Nit: I would prefer to see the validators just below the corresponding type definition. IMO it makes it harder for people to forget to update validators when updating the types.

shared/tunnelbroker_messages/src/messages/mod.rs
21–30 ↗	(On Diff #32427)	In Rust we normally use `//` for each line instead of multiline comments.

This revision is now accepted and ready to land.Oct 30 2023, 6:07 AM

address review

In D9596#281960, @michal wrote:

Nit: I would prefer to see the validators just below the corresponding type definition. IMO it makes it harder for people to forget to update validators when updating the types.

yeah agree

Harbormaster failed remote builds in B23607: Diff 32550!Oct 31 2023, 8:30 AM

CI

Harbormaster failed remote builds in B23618: Diff 32561!Oct 31 2023, 10:53 AM

Harbormaster completed remote builds in B23618: Diff 32561.Nov 1 2023, 10:16 AM

Closed by commit rCOMM972d6ddf9e0a: [lib] define Tunnelbroker API in Flow types (authored by kamil). · Explain WhyNov 6 2023, 8:30 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM972d6ddf9e0a: [lib] define Tunnelbroker API in Flow types.

kamil mentioned this in D10832: [lib] Tunnelbroker support for unauthorized sessions.Jan 29 2024, 3:28 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

tunnelbroker/

connection-initialization-response-types.js

26 lines

19 lines

message-receive-confirmation-types.js

17 lines

message-to-device-request-status-types.js

40 lines

message-to-device-request-types.js

21 lines

message-to-device-types.js

21 lines

74 lines

session-types.js

31 lines

shared/

tunnelbroker_messages/

src/

messages/

8 lines

Diff 32801

lib/types/tunnelbroker/connection-initialization-response-types.js

Loading...

lib/types/tunnelbroker/keys-types.js

Loading...

lib/types/tunnelbroker/message-receive-confirmation-types.js

Loading...

lib/types/tunnelbroker/message-to-device-request-status-types.js

Loading...

lib/types/tunnelbroker/message-to-device-request-types.js

Loading...

lib/types/tunnelbroker/message-to-device-types.js

Loading...

lib/types/tunnelbroker/messages.js

Loading...

lib/types/tunnelbroker/session-types.js

Loading...

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...