Paths

Table of Contentst

-
lib/
-
hooks/
-
disconnected-bar.js
-
selectors/
-
keyserver-selectors.js
-
server-calls.js
-
socket/
-
activity-handler.react.js
-
api-request-handler.react.js
-
calendar-query-handler.react.js
-
request-response-handler.react.js
-
update-handler.react.js
-
native/
-
calendar/
-
calendar.react.js
-
entry.react.js
-
media/
-
encrypted-image.react.js
-
remote-image.react.js
-
push/
-
push-handler.react.js
-
socket.react.js
-
web/
-
calendar/
-
entry.react.js
-
push-notif/
-
badge-handler.react.js
-
socket.react.js

Differential D9680

[lib][web][native] Refactor connectionSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 4:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 21, 10:36 AM

	Unknown Object (File)
	Wed, Mar 19, 5:58 PM

	Unknown Object (File)
	Mar 1 2025, 7:35 AM

	Unknown Object (File)
	Mar 1 2025, 7:35 AM

	Unknown Object (File)
	Mar 1 2025, 7:35 AM

	Unknown Object (File)
	Mar 1 2025, 7:35 AM

	Unknown Object (File)
	Mar 1 2025, 7:29 AM

	Unknown Object (File)
	Feb 20 2025, 2:17 AM

View All 88 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector

Summary

issue: https://linear.app/comm/issue/ENG-5000/refactor-connectionselector

Test Plan

Tested that the selector works by calling useSelector(connectionSelector('256')); and printing the result

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 3 2023, 4:27 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 4:27 AM

inka added a parent revision: D9621: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector.Nov 3 2023, 4:27 AM

Harbormaster completed remote builds in B23703: Diff 32662.Nov 3 2023, 4:45 AM

inka requested review of this revision.Nov 3 2023, 4:45 AM

inka added a child revision: D9681: [lib][web][native] Refactor urlPrefixSelector.Nov 3 2023, 4:46 AM

Make code prettier

Harbormaster completed remote builds in B23710: Diff 32669.Nov 3 2023, 6:20 AM

kamil accepted this revision.Nov 7 2023, 3:01 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:01 AM

Closed by commit rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

disconnected-bar.js

5 lines

selectors/

keyserver-selectors.js

11 lines

server-calls.js

2 lines

socket/

activity-handler.react.js

3 lines

api-request-handler.react.js

3 lines

calendar-query-handler.react.js

3 lines

request-response-handler.react.js

3 lines

update-handler.react.js

3 lines

native/

calendar/

calendar.react.js

3 lines

3 lines

media/

encrypted-image.react.js

3 lines

remote-image.react.js

3 lines

push/

push-handler.react.js

2 lines

socket.react.js

2 lines

web/

calendar/

3 lines

push-notif/

badge-handler.react.js

3 lines

socket.react.js

2 lines

Diff 32993

lib/hooks/disconnected-bar.js

This file was added.

				.buttonIcon {
				color: var(--drawer-expand-button);
				}

				.disabledButtonIcon {
				color: var(--drawer-expand-button-disabled);
				}

				.button {
				font-size: var(--xs-font-12);
				width: 24px;
				height: 24px;
				}

lib/selectors/keyserver-selectors.js

This file was added.

				.buttonIcon {
				color: var(--drawer-expand-button);
				}

				.disabledButtonIcon {
				color: var(--drawer-expand-button-disabled);
				}

				.button {
				font-size: var(--xs-font-12);
				width: 24px;
				height: 24px;
				}

lib/selectors/server-calls.js

This file was added.

				.buttonIcon {
				color: var(--drawer-expand-button);
				}

				.disabledButtonIcon {
				color: var(--drawer-expand-button-disabled);
				}

				.button {
				font-size: var(--xs-font-12);
				width: 24px;
				height: 24px;
				}

lib/socket/activity-handler.react.js

This file was added.

				.buttonIcon {
				color: var(--drawer-expand-button);
				}

				.disabledButtonIcon {
				color: var(--drawer-expand-button-disabled);
				}

				.button {
				font-size: var(--xs-font-12);
				width: 24px;
				height: 24px;
				}

lib/socket/api-request-handler.react.js

Loading...

lib/socket/calendar-query-handler.react.js

Loading...

lib/socket/request-response-handler.react.js

Loading...

lib/socket/update-handler.react.js

Loading...

native/calendar/calendar.react.js

Loading...

native/calendar/entry.react.js

Loading...

native/media/encrypted-image.react.js

Loading...

native/media/remote-image.react.js

Loading...

native/push/push-handler.react.js

Loading...

native/socket.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/push-notif/badge-handler.react.js

Loading...

web/socket.react.js

Loading...