Page MenuHomePhabricator
Differential D9732

[lib][web][native] Refactor sessionIDSelector
ClosedPublic
Actions

Authored by inka on Nov 6 2023, 9:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 5:03 PM
Unknown Object (File)
Sat, Mar 1, 7:35 AM
Unknown Object (File)
Sat, Mar 1, 7:35 AM
Unknown Object (File)
Sat, Mar 1, 7:35 AM
Unknown Object (File)
Sat, Mar 1, 7:29 AM
Unknown Object (File)
Feb 3 2025, 4:00 PM
Unknown Object (File)
Feb 3 2025, 4:00 PM
Unknown Object (File)
Feb 3 2025, 3:58 PM
View All 67 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMMaa4a1a089ce0: [lib][web][native] Refactor sessionIDSelector
Summary

issue: https://linear.app/comm/issue/ENG-5004/refactor-sessionidselector

Test Plan

Tested that the refactored selectors work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
selectors/
3 lines
9 lines
2 lines
shared/
2 lines
web/
selectors/
23 lines
4 lines

Diff 32997

View Options

lib/selectors/account-selectors.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

lib/selectors/keyserver-selectors.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

lib/selectors/server-calls.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

lib/shared/session-utils.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/selectors/socket-selectors.js

Loading...
View Options

web/socket.react.js

Loading...