[lib][web][native] Refactor sessionIDSelector
ClosedPublic
Actions

Authored by inka on Nov 6 2023, 5:26 PM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMMaa4a1a089ce0: [lib][web][native] Refactor sessionIDSelector

Summary

issue: https://linear.app/comm/issue/ENG-5004/refactor-sessionidselector

Test Plan

Tested that the refactored selectors work

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 6 2023, 5:26 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 6 2023, 5:26 PM

inka added a parent revision: D9729: [lib][web][native] Refactor preRequestUserStateSelector.Nov 6 2023, 5:28 PM

inka added a child revision: D9733: [lib][web][native] Refactor cookieSelector.Nov 6 2023, 5:45 PM

Harbormaster completed remote builds in B23806: Diff 32819.Nov 6 2023, 6:10 PM

inka requested review of this revision.Nov 6 2023, 6:10 PM

kamil accepted this revision.Nov 7 2023, 11:25 AM

This revision is now accepted and ready to land.Nov 7 2023, 11:25 AM

Closed by commit rCOMMaa4a1a089ce0: [lib][web][native] Refactor sessionIDSelector. · Explain WhyNov 9 2023, 9:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMaa4a1a089ce0: [lib][web][native] Refactor sessionIDSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

account-selectors.js

3 lines

keyserver-selectors.js

9 lines

server-calls.js

2 lines

shared/

session-utils.js

2 lines

web/

selectors/

socket-selectors.js

23 lines

socket.react.js

4 lines

Diff 32997

View Options

lib/selectors/account-selectors.js

View Options

lib/selectors/keyserver-selectors.js

View Options

lib/selectors/server-calls.js

View Options

lib/shared/session-utils.js

View Options

web/selectors/socket-selectors.js

View Options

[lib][web][native] Refactor sessionIDSelectorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32997

lib/selectors/account-selectors.js

lib/selectors/keyserver-selectors.js

lib/selectors/server-calls.js

lib/shared/session-utils.js

web/selectors/socket-selectors.js

web/socket.react.js

[lib][web][native] Refactor sessionIDSelector
ClosedPublic
Actions

Revision Contents
Changeset List