[lib][web][native] Refactor urlPrefixSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 4:45 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector

Summary

issue: https://linear.app/comm/issue/ENG-5001/refactor-urlprefixselector

Test Plan

Tested that the selector works by calling useSelector(urlPrefixSelector('256')); and printing the result. Tested the openSocketSelector by running the app and checking that it is possible to send messages

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 3 2023, 4:45 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 4:45 AM

inka added a parent revision: D9680: [lib][web][native] Refactor connectionSelector.Nov 3 2023, 4:46 AM

Harbormaster completed remote builds in B23704: Diff 32663.Nov 3 2023, 5:03 AM

inka requested review of this revision.Nov 3 2023, 5:03 AM

Make code prettier

Harbormaster completed remote builds in B23709: Diff 32668.Nov 3 2023, 5:56 AM

inka added a child revision: D9684: [lib][web][native] Refactor currentAsOfSelector.Nov 3 2023, 6:56 AM

kamil accepted this revision.Nov 7 2023, 3:03 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:03 AM

Closed by commit rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

9 lines

server-calls.js

2 lines

native/

account/

logged-out-modal.react.js

2 lines

data/

sqlite-data-handler.js

2 lines

profile/

custom-server-modal.react.js

3 lines

dev-tools.react.js

3 lines

selectors/

socket-selectors.js

11 lines

socket.react.js

4 lines

web/

selectors/

socket-selectors.js

11 lines

socket.react.js

4 lines

Diff 32992

View Options

lib/selectors/keyserver-selectors.js

View Options

lib/selectors/server-calls.js

View Options

native/account/logged-out-modal.react.js

View Options

native/data/sqlite-data-handler.js

View Options

native/profile/custom-server-modal.react.js

View Options

native/profile/dev-tools.react.js

View Options

native/selectors/socket-selectors.js

View Options

native/socket.react.js

View Options

web/selectors/socket-selectors.js

View Options

[lib][web][native] Refactor urlPrefixSelectorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32992

lib/selectors/keyserver-selectors.js

lib/selectors/server-calls.js

native/account/logged-out-modal.react.js

native/data/sqlite-data-handler.js

native/profile/custom-server-modal.react.js

native/profile/dev-tools.react.js

native/selectors/socket-selectors.js

native/socket.react.js

web/selectors/socket-selectors.js

web/socket.react.js

[lib][web][native] Refactor urlPrefixSelector
ClosedPublic
Actions

Revision Contents
Changeset List