Page MenuHomePhabricator
Differential D9763

[lib] Inline reduceUpdatesCurrentAsOf
ClosedPublic
Actions

Authored by inka on Nov 8 2023, 6:17 AM.
Tags
None
Referenced Files
F2897186: D9763.diff
Fri, Oct 4, 10:12 PM
Unknown Object (File)
Tue, Oct 1, 7:27 PM
Unknown Object (File)
Sat, Sep 28, 3:49 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
Unknown Object (File)
Sep 4 2024, 7:43 AM
View All 64 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM301aa46c672d: [lib] Inline reduceUpdatesCurrentAsOf
Summary

issue:https://linear.app/comm/issue/ENG-5349/inline-reduceupdatescurrentasof
processUpdatesActionType is dispatched only from UpdateHandler when a message comes to a socket. Sockets are keyserver specific, so the data is also keyserver specific

Test Plan

Tested logInActionTypes and processUpdatesActionType. Assuming the rest works by symmetry (see the deleted file for how it was before)

Diff Detail

Repository
rCOMM Comm
Branch
inka/reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Nov 8 2023, 6:17 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 8 2023, 6:18 AM
inka added a parent revision: D9750: [lib] Refactor keyserver reducer pt.1.Nov 8 2023, 6:18 AM
inka published this revision for review.Nov 8 2023, 6:20 AM
inka retitled this revision from [lib] Inline updates reducer to [lib] Inline reduceUpdatesCurrentAsOf.Nov 8 2023, 6:25 AM
inka edited the summary of this revision. (Show Details)Nov 8 2023, 6:50 AM
Harbormaster completed remote builds in B23905: Diff 32942.Nov 8 2023, 11:47 AM
inka added a child revision: D9764: [lib] Inline reduceLastCommunicatedPlatformDetails.Nov 9 2023, 3:34 AM
inka updated this revision to Diff 33200.Nov 14 2023, 12:59 AM
inka edited the summary of this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B24100: Diff 33200.Nov 14 2023, 1:20 AM
michal added inline comments.Nov 14 2023, 4:10 AM
lib/reducers/keyserver-reducer.js
125 ↗(On Diff #33200)

Shouldn't this be keyserverID?

inka updated this revision to Diff 33313.Nov 16 2023, 1:06 AM

Rebase and address review

Harbormaster completed remote builds in B24190: Diff 33313.Nov 16 2023, 1:25 AM
michal accepted this revision.Nov 16 2023, 4:52 AM
This revision is now accepted and ready to land.Nov 16 2023, 4:52 AM
Closed by commit rCOMM301aa46c672d: [lib] Inline reduceUpdatesCurrentAsOf (authored by inka). · Explain WhyNov 22 2023, 7:24 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM301aa46c672d: [lib] Inline reduceUpdatesCurrentAsOf.

Revision Contents
Changeset List

Diff 32942

View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/reducers/updates-reducer.js

Loading...
View Options

lib/socket/socket.react.js

Loading...
View Options

lib/socket/update-handler.react.js

Loading...
View Options

lib/types/socket-types.js

Loading...
View Options

lib/types/update-types.js

Loading...