Page MenuHomePhabricator

[native] update remove keyserver text based on connection status
ClosedPublic

Authored by ginsu on Nov 9 2023, 12:18 AM.
Tags
None
Referenced Files
F3516182: D9794.diff
Sun, Dec 22, 12:41 PM
Unknown Object (File)
Thu, Dec 5, 3:09 PM
Unknown Object (File)
Thu, Dec 5, 12:50 PM
Unknown Object (File)
Sun, Nov 24, 11:27 PM
Unknown Object (File)
Sun, Nov 24, 7:37 PM
Unknown Object (File)
Oct 27 2024, 11:48 PM
Unknown Object (File)
Oct 27 2024, 11:48 PM
Unknown Object (File)
Oct 27 2024, 11:48 PM
Subscribers

Details

Summary

In the designs for the keyserver selection bottomsheet, the text of the keyserver remove info and the remove button are different depending if you are connected to the selected keyserver or not. This diff introduces this functionality to the keyserver selection bottomsheet

For context here are the figma designs:

connected:

Screenshot 2023-11-09 at 3.21.58 AM.png (1×758 px, 126 KB)

disconnected:
Screenshot 2023-11-09 at 3.21.53 AM.png (1×726 px, 129 KB)

Linear task: https://linear.app/comm/issue/ENG-5469/introduce-keyserverselectionbottomsheet-component-ui

Depends on D9756

Test Plan

Please see the screenshots below

connected:

Screenshot 2023-11-09 at 2.38.35 AM.png (1×1 px, 741 KB)

disconnected:

Screenshot 2023-11-09 at 2.38.30 AM.png (1×1 px, 760 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I'm wondering if this will result in flickering screen considering how often the disconnected bar appears / disappears on prod. Do you have any way of testing this?

I'm wondering if this will result in flickering screen considering how often the disconnected bar appears / disappears on prod. Do you have any way of testing this?

This would make the bottomsheet move up and down a lot. To prevent this, I passed the connectionInfo as a navigation param so that users won't experience this. We still need to consider what happens if a keyserver gets disconnected when the bottomsheet is up and before the user presses the disconnect button, but at the moment, I'm thinking we can do a "last second" check at the beginning of the onPress callback to see if the keyserver is still active. If it isn't we can alert the user that something went wrong and to check the connection of the keyserver

I'm thinking we can do a "last second" check at the beginning of the onPress callback to see if the keyserver is still active. If it isn't we can alert the user that something went wrong and to check the connection of the keyserver

Sounds good!

To prevent this, I passed the connectionInfo as a navigation param so that users won't experience this.

Oh, I see, nice! Thank you for explaining!

Accepting, but we need to figure out D9828 before landing this. Also - shouldn't these diffs be in one stack somehow? I'm having a hard time navigating and finding all diffs

This revision is now accepted and ready to land.Nov 14 2023, 12:20 AM

Accepting, but we need to figure out D9828 before landing this

Looks like we figured out the copy in D9828. Going to land this diff now, but if there was something more you wanted me to address, please lmk and I will make a follow up diff.

Also - shouldn't these diffs be in one stack somehow? I'm having a hard time navigating and finding all diffs

Sorry about that! I think one of the diffs in the stack didn't get chained properly, I'll be more careful about that in the future