Differential D9796

[lib] implement `UserStore` spec
ClosedPublic
Actions

Authored by kamil on Nov 9 2023, 6:04 AM.

Tags

None

Referenced Files

	F3648960: D9796.diff
	Sun, Jan 5, 4:16 AM

	Unknown Object (File)
	Sat, Jan 4, 7:22 PM

	Unknown Object (File)
	Sat, Jan 4, 7:18 PM

	Unknown Object (File)
	Tue, Dec 31, 6:30 AM

	Unknown Object (File)
	Tue, Dec 31, 6:30 AM

	Unknown Object (File)
	Tue, Dec 31, 6:30 AM

	Unknown Object (File)
	Tue, Dec 31, 6:22 AM

	Unknown Object (File)
	Dec 4 2024, 9:18 AM

View All 56 Files

Subscribers

Details

Reviewers

Commits

rCOMMd0e30e99fa5f: [lib] implement `UserStore` spec

Summary

Add code with required ops.

DB function are implemented later in the stack.

Depends on D9761

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2023, 6:04 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:04 AM

kamil added a child revision: D9797: [lib] refactor joining thread to ops.Nov 9 2023, 6:06 AM

Harbormaster completed remote builds in B23955: Diff 33007.Nov 9 2023, 6:40 AM

kamil published this revision for review.Nov 10 2023, 1:52 AM

tomek accepted this revision.Nov 13 2023, 6:25 AM

tomek added inline comments.

lib/ops/user-store-ops.js
6–24 ↗	(On Diff #33007)	At some point we could consider making this logic more generic - I guess the operations are quite similar for all the stores.
74–79 ↗	(On Diff #33007)	I guess these are implemented later in the stack, right?

This revision is now accepted and ready to land.Nov 13 2023, 6:25 AM

kamil added inline comments.Nov 16 2023, 6:45 AM

lib/ops/user-store-ops.js
74–79 ↗	(On Diff #33007)	yes - D9909

kamil mentioned this in D9904: [SQLite] add methods to operate on users table.Nov 16 2023, 7:06 AM

Closed by commit rCOMMd0e30e99fa5f: [lib] implement `UserStore` spec (authored by kamil). · Explain WhyNov 16 2023, 7:21 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd0e30e99fa5f: [lib] implement `UserStore` spec.

Revision Contents
Changeset List

Path

Size

lib/

ops/

user-store-ops.js

82 lines

Diff 33334

lib/ops/user-store-ops.js

Loading...