Differential D9797

[lib] refactor joining thread to ops
ClosedPublic
Actions

Authored by kamil on Nov 9 2023, 6:06 AM.

Details

Reviewers

tomek

Commits

rCOMM765f9f250984: [lib] refactor joining thread to ops

Summary

Convert logic for ops approach.

Tested that newUserInfos contains only new/updated users so should not be issues in performance terms.

Depends on D9796

Test Plan

Create thread
Join thread
Join thread with user not being aware of

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2023, 6:06 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:07 AM

kamil added a child revision: D9798: [lib] refactor login action in `UserStore` to ops.Nov 9 2023, 6:16 AM

Harbormaster failed remote builds in B23956: Diff 33008!Nov 9 2023, 6:47 AM

kamil published this revision for review.Nov 10 2023, 1:53 AM

tomek accepted this revision.Nov 13 2023, 6:31 AM

This revision is now accepted and ready to land.Nov 13 2023, 6:31 AM

Harbormaster completed remote builds in B23956: Diff 33008.Nov 15 2023, 1:38 PM

Closed by commit rCOMM765f9f250984: [lib] refactor joining thread to ops (authored by kamil). · Explain WhyNov 16 2023, 7:21 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM765f9f250984: [lib] refactor joining thread to ops.

Revision Contents
Changeset List

Path

Size

lib/

ops/

user-store-ops.js

12 lines

reducers/

user-reducer.js

36 lines

Diff 33333

View Options

lib/ops/user-store-ops.js