Convert logic for ops approach.
Tested that newUserInfos contains only new/updated users so should not be issues in performance terms.
Depends on D9796
Paths
| Differential D9797 Authored by kamil on Nov 9 2023, 6:06 AM.
Details
Summary Convert logic for ops approach. Tested that newUserInfos contains only new/updated users so should not be issues in performance terms. Depends on D9796 Test Plan
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added subscribers: will, ashoat. · View Herald TranscriptNov 9 2023, 6:07 AM2023-11-09 06:07:00 (UTC-8) Harbormaster failed remote builds in B23956: Diff 33008!Nov 9 2023, 6:47 AM2023-11-09 06:47:16 (UTC-8) This revision is now accepted and ready to land.Nov 13 2023, 6:31 AM2023-11-13 06:31:54 (UTC-8) Harbormaster completed remote builds in B23956: Diff 33008.Nov 15 2023, 1:38 PM2023-11-15 13:38:18 (UTC-8) Closed by commit rCOMM765f9f250984: [lib] refactor joining thread to ops (authored by kamil). · Explain WhyNov 16 2023, 7:21 AM2023-11-16 07:21:43 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33333 lib/ops/user-store-ops.js
lib/reducers/user-reducer.js
|
Do we really want to make this change in production? Should we consider gating it on isStaffRelease?