Page MenuHomePhabricator

[SQLite] implement C++ user store ops
ClosedPublic

Authored by kamil on Nov 16 2023, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:30 AM
Unknown Object (File)
Tue, Dec 31, 6:22 AM
Unknown Object (File)
Wed, Dec 25, 9:01 AM
Unknown Object (File)
Mon, Dec 9, 8:51 AM
Subscribers

Details

Summary

Code for native ops

Depends on D9909

Test Plan

Code for testing:

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '1',
      userInfo: 'fdfd',
    },
  },
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_users',
    payload: {
      ids: ['1'],
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_all_users',
  },
]);

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Nov 16 2023, 9:12 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20 ↗(On Diff #33342)

Is it intentional to return an empty array? Is it implemented later in the stack?

This revision is now accepted and ready to land.Nov 17 2023, 7:46 AM
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20 ↗(On Diff #33342)

it's implemented in next diff: D9911

This revision was automatically updated to reflect the committed changes.