Page MenuHomePhabricator
Differential D9914

[native] read users from SQLite on app start
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 6:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:07 PM
Unknown Object (File)
Mon, Mar 17, 8:07 PM
Unknown Object (File)
Mon, Mar 17, 8:07 PM
Unknown Object (File)
Mon, Mar 17, 8:07 PM
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:00 PM
Unknown Object (File)
Feb 20 2025, 10:09 AM
Unknown Object (File)
Feb 16 2025, 4:40 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM11d86ef080fd: [native] read users from SQLite on app start
Summary

Get data from DB and populate store.

Only native, web is in progress and those changes shouldn't affect anything.

Depends on D9913

Test Plan

Test if contents are the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 16 2023, 6:43 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 6:43 AM
Harbormaster failed remote builds in B24205: Diff 33330!Nov 16 2023, 7:33 AM
kamil updated this revision to Diff 33346.Nov 16 2023, 8:24 AM

rebase

kamil published this revision for review.Nov 16 2023, 9:43 AM
Harbormaster failed remote builds in B24213: Diff 33346!Nov 16 2023, 9:46 AM
Harbormaster completed remote builds in B24213: Diff 33346.Nov 16 2023, 10:06 AM
tomek accepted this revision.Nov 17 2023, 7:58 AM
tomek added inline comments.
lib/reducers/user-reducer.js
401–407 ↗(On Diff #33346)

Maybe add a comment that we're going to return users from the payload after we confirm that the solution works correctly.

This revision is now accepted and ready to land.Nov 17 2023, 7:58 AM
kamil updated this revision to Diff 33405.Nov 20 2023, 4:07 AM

add comment

Harbormaster completed remote builds in B24267: Diff 33405.Nov 20 2023, 4:26 AM
Closed by commit rCOMM11d86ef080fd: [native] read users from SQLite on app start (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM11d86ef080fd: [native] read users from SQLite on app start.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
14 lines
types/
3 lines
native/
data/
13 lines

Diff 33426

View Options

lib/reducers/message-reducer.test.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesfunction convertUserInfosToReplaceUserOps(
userInfos: UserInfos, userInfos: UserInfos,
): $ReadOnlyArray<UserStoreOperation> { ): $ReadOnlyArray<UserStoreOperation> {
return values(userInfos).map(userInfo => ({ return values(userInfos).map(userInfo => ({
type: 'replace_user', type: 'replace_user',
payload: userInfo, payload: userInfo,
})); }));
} }
function convertUserInfoToClientDBUserInfo(user: UserInfo): ClientDBUserInfo {
return {
id: user.id,
userInfo: JSON.stringify(user),
};
}
const userStoreOpsHandlers: BaseStoreOpsHandlers< const userStoreOpsHandlers: BaseStoreOpsHandlers<
UserInfos, UserInfos,
UserStoreOperation, UserStoreOperation,
ClientDBUserStoreOperation, ClientDBUserStoreOperation,
UserInfos, UserInfos,
ClientDBUserInfo, ClientDBUserInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 14 Lines for (const operation: UserStoreOperation of ops) {
} }
} else if (operation.type === 'remove_all_users') { } else if (operation.type === 'remove_all_users') {
processedUserInfos = {}; processedUserInfos = {};
} }
} }
return processedUserInfos; return processedUserInfos;
}, },
convertOpsToClientDBOps(): $ReadOnlyArray<ClientDBUserStoreOperation> { convertOpsToClientDBOps(
return []; ops: $ReadOnlyArray<UserStoreOperation>,
): $ReadOnlyArray<ClientDBUserStoreOperation> {
return ops.map(operation => {
if (
operation.type === 'remove_users' ||
operation.type === 'remove_all_users'
) {
return operation;
}
return {
type: 'replace_user',
payload: convertUserInfoToClientDBUserInfo(operation.payload),
};
});
}, },
translateClientDBData(): UserInfos { translateClientDBData(users: $ReadOnlyArray<ClientDBUserInfo>): UserInfos {
return {}; const userInfos: { [id: string]: UserInfo } = {};
users.forEach(dbUser => {
userInfos[dbUser.id] = JSON.parse(dbUser.userInfo);
});
return userInfos;
}, },
}; };
export { userStoreOpsHandlers, convertUserInfosToReplaceUserOps }; export {
userStoreOpsHandlers,
convertUserInfosToReplaceUserOps,
convertUserInfoToClientDBUserInfo,
};
View Options

lib/reducers/user-reducer.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesfunction convertUserInfosToReplaceUserOps(
userInfos: UserInfos, userInfos: UserInfos,
): $ReadOnlyArray<UserStoreOperation> { ): $ReadOnlyArray<UserStoreOperation> {
return values(userInfos).map(userInfo => ({ return values(userInfos).map(userInfo => ({
type: 'replace_user', type: 'replace_user',
payload: userInfo, payload: userInfo,
})); }));
} }
function convertUserInfoToClientDBUserInfo(user: UserInfo): ClientDBUserInfo {
return {
id: user.id,
userInfo: JSON.stringify(user),
};
}
const userStoreOpsHandlers: BaseStoreOpsHandlers< const userStoreOpsHandlers: BaseStoreOpsHandlers<
UserInfos, UserInfos,
UserStoreOperation, UserStoreOperation,
ClientDBUserStoreOperation, ClientDBUserStoreOperation,
UserInfos, UserInfos,
ClientDBUserInfo, ClientDBUserInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 14 Lines for (const operation: UserStoreOperation of ops) {
} }
} else if (operation.type === 'remove_all_users') { } else if (operation.type === 'remove_all_users') {
processedUserInfos = {}; processedUserInfos = {};
} }
} }
return processedUserInfos; return processedUserInfos;
}, },
convertOpsToClientDBOps(): $ReadOnlyArray<ClientDBUserStoreOperation> { convertOpsToClientDBOps(
return []; ops: $ReadOnlyArray<UserStoreOperation>,
): $ReadOnlyArray<ClientDBUserStoreOperation> {
return ops.map(operation => {
if (
operation.type === 'remove_users' ||
operation.type === 'remove_all_users'
) {
return operation;
}
return {
type: 'replace_user',
payload: convertUserInfoToClientDBUserInfo(operation.payload),
};
});
}, },
translateClientDBData(): UserInfos { translateClientDBData(users: $ReadOnlyArray<ClientDBUserInfo>): UserInfos {
return {}; const userInfos: { [id: string]: UserInfo } = {};
users.forEach(dbUser => {
userInfos[dbUser.id] = JSON.parse(dbUser.userInfo);
});
return userInfos;
}, },
}; };
export { userStoreOpsHandlers, convertUserInfosToReplaceUserOps }; export {
userStoreOpsHandlers,
convertUserInfosToReplaceUserOps,
convertUserInfoToClientDBUserInfo,
};
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesfunction convertUserInfosToReplaceUserOps(
userInfos: UserInfos, userInfos: UserInfos,
): $ReadOnlyArray<UserStoreOperation> { ): $ReadOnlyArray<UserStoreOperation> {
return values(userInfos).map(userInfo => ({ return values(userInfos).map(userInfo => ({
type: 'replace_user', type: 'replace_user',
payload: userInfo, payload: userInfo,
})); }));
} }
function convertUserInfoToClientDBUserInfo(user: UserInfo): ClientDBUserInfo {
return {
id: user.id,
userInfo: JSON.stringify(user),
};
}
const userStoreOpsHandlers: BaseStoreOpsHandlers< const userStoreOpsHandlers: BaseStoreOpsHandlers<
UserInfos, UserInfos,
UserStoreOperation, UserStoreOperation,
ClientDBUserStoreOperation, ClientDBUserStoreOperation,
UserInfos, UserInfos,
ClientDBUserInfo, ClientDBUserInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 14 Lines for (const operation: UserStoreOperation of ops) {
} }
} else if (operation.type === 'remove_all_users') { } else if (operation.type === 'remove_all_users') {
processedUserInfos = {}; processedUserInfos = {};
} }
} }
return processedUserInfos; return processedUserInfos;
}, },
convertOpsToClientDBOps(): $ReadOnlyArray<ClientDBUserStoreOperation> { convertOpsToClientDBOps(
return []; ops: $ReadOnlyArray<UserStoreOperation>,
): $ReadOnlyArray<ClientDBUserStoreOperation> {
return ops.map(operation => {
if (
operation.type === 'remove_users' ||
operation.type === 'remove_all_users'
) {
return operation;
}
return {
type: 'replace_user',
payload: convertUserInfoToClientDBUserInfo(operation.payload),
};
});
}, },
translateClientDBData(): UserInfos { translateClientDBData(users: $ReadOnlyArray<ClientDBUserInfo>): UserInfos {
return {}; const userInfos: { [id: string]: UserInfo } = {};
users.forEach(dbUser => {
userInfos[dbUser.id] = JSON.parse(dbUser.userInfo);
});
return userInfos;
}, },
}; };
export { userStoreOpsHandlers, convertUserInfosToReplaceUserOps }; export {
userStoreOpsHandlers,
convertUserInfosToReplaceUserOps,
convertUserInfoToClientDBUserInfo,
};
View Options

native/data/sqlite-data-handler.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesfunction convertUserInfosToReplaceUserOps(
userInfos: UserInfos, userInfos: UserInfos,
): $ReadOnlyArray<UserStoreOperation> { ): $ReadOnlyArray<UserStoreOperation> {
return values(userInfos).map(userInfo => ({ return values(userInfos).map(userInfo => ({
type: 'replace_user', type: 'replace_user',
payload: userInfo, payload: userInfo,
})); }));
} }
function convertUserInfoToClientDBUserInfo(user: UserInfo): ClientDBUserInfo {
return {
id: user.id,
userInfo: JSON.stringify(user),
};
}
const userStoreOpsHandlers: BaseStoreOpsHandlers< const userStoreOpsHandlers: BaseStoreOpsHandlers<
UserInfos, UserInfos,
UserStoreOperation, UserStoreOperation,
ClientDBUserStoreOperation, ClientDBUserStoreOperation,
UserInfos, UserInfos,
ClientDBUserInfo, ClientDBUserInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 14 Lines for (const operation: UserStoreOperation of ops) {
} }
} else if (operation.type === 'remove_all_users') { } else if (operation.type === 'remove_all_users') {
processedUserInfos = {}; processedUserInfos = {};
} }
} }
return processedUserInfos; return processedUserInfos;
}, },
convertOpsToClientDBOps(): $ReadOnlyArray<ClientDBUserStoreOperation> { convertOpsToClientDBOps(
return []; ops: $ReadOnlyArray<UserStoreOperation>,
): $ReadOnlyArray<ClientDBUserStoreOperation> {
return ops.map(operation => {
if (
operation.type === 'remove_users' ||
operation.type === 'remove_all_users'
) {
return operation;
}
return {
type: 'replace_user',
payload: convertUserInfoToClientDBUserInfo(operation.payload),
};
});
}, },
translateClientDBData(): UserInfos { translateClientDBData(users: $ReadOnlyArray<ClientDBUserInfo>): UserInfos {
return {}; const userInfos: { [id: string]: UserInfo } = {};
users.forEach(dbUser => {
userInfos[dbUser.id] = JSON.parse(dbUser.userInfo);
});
return userInfos;
}, },
}; };
export { userStoreOpsHandlers, convertUserInfosToReplaceUserOps }; export {
userStoreOpsHandlers,
convertUserInfosToReplaceUserOps,
convertUserInfoToClientDBUserInfo,
};