Page MenuHomePhabricator
Differential D9761

[lib/web/native] implement asserting store after processing ops for both web and native
ClosedPublic
Actions

Authored by kamil on Nov 8 2023, 5:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:06 PM
Unknown Object (File)
Mon, Mar 17, 8:00 PM
Unknown Object (File)
Thu, Mar 6, 12:58 PM
Unknown Object (File)
Feb 18 2025, 11:32 AM
View All Files
Subscribers
ashoat
will

Details

Reviewers
atul
tomek
Commits
rCOMM26e5bd95b1f4: [lib/web/native] implement asserting store after processing ops for both web…
Summary

This is a pattern we used in the past, but now I want to make it work on all platforms.

Depends on D9759

Test Plan

Call assertUserStoresAreEqual and check the result:
web:

image.png (648×958 px, 116 KB)

native:
image.png (1×828 px, 654 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 8 2023, 5:01 AM
kamil held this revision as a draft.
Herald added subscribers: will, ashoat. · View Herald TranscriptNov 8 2023, 5:01 AM
kamil edited the test plan for this revision. (Show Details)Nov 8 2023, 5:35 AM
kamil published this revision for review.Nov 8 2023, 5:44 AM
kamil added inline comments.
lib/reducers/user-reducer.js
139 ↗(On Diff #32938)

UserStore here is probably redundant (look at screenshots)

149 ↗(On Diff #32938)

I'll remove those in the next diff (here and line 125)

lib/utils/objects.js
122 ↗(On Diff #32938)

it's safe, we don't call this function anywhere (in code before this diff), in this diff it's handled properly

native/redux/redux-debug-utils.js
6 ↗(On Diff #32938)

I use this, not native/utils/alert.js on purpose.

This code can be called from the reducer, our own Alert calls store.getState() which cause crashes

tomek accepted this revision.Nov 8 2023, 6:21 AM
This revision is now accepted and ready to land.Nov 8 2023, 6:21 AM
Harbormaster completed remote builds in B23901: Diff 32938.Nov 8 2023, 11:20 AM
kamil removed a parent revision: D9759: [native] cleanup SQLite handler code.Nov 9 2023, 5:44 AM
kamil updated this revision to Diff 33006.Nov 9 2023, 6:03 AM
kamil added a parent revision: D9759: [native] cleanup SQLite handler code.

add console.log

kamil added a child revision: D9796: [lib] implement `UserStore` spec.Nov 9 2023, 6:04 AM
Harbormaster completed remote builds in B23954: Diff 33006.Nov 9 2023, 6:23 AM
kamil updated this revision to Diff 33287.Nov 15 2023, 12:05 PM

rebase

Harbormaster completed remote builds in B24169: Diff 33287.Nov 15 2023, 1:25 PM
Closed by commit rCOMM26e5bd95b1f4: [lib/web/native] implement asserting store after processing ops for both web… (authored by kamil). · Explain WhyNov 16 2023, 7:21 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM26e5bd95b1f4: [lib/web/native] implement asserting store after processing ops for both web….

Revision Contents
Changeset List

PathSize
lib/
reducers/
13 lines
30 lines
utils/
3 lines
native/
redux/
9 lines
7 lines
web/
redux/
7 lines
3 lines

Diff 33332

View Options

lib/reducers/master-reducer.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: ( const baseLastCommunicatedPlatformDetailsSelector: (
state: AppState, keyserverID: string,
) => ?PlatformDetails = (state: AppState) => ) => (state: AppState) => ?PlatformDetails = keyserverID => (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID] state.keyserverStore.keyserverInfos[keyserverID]
?.lastCommunicatedPlatformDetails; ?.lastCommunicatedPlatformDetails;
const lastCommunicatedPlatformDetailsSelector: (
keyserverID: string,
) => (state: AppState) => ?PlatformDetails = _memoize(
baseLastCommunicatedPlatformDetailsSelector,
);
const selectedKeyserversSelector: ( const selectedKeyserversSelector: (
state: AppState, state: AppState,
) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector( ) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(
(state: AppState) => state.keyserverStore.keyserverInfos, (state: AppState) => state.keyserverStore.keyserverInfos,
(state: AppState) => state.userStore.userInfos, (state: AppState) => state.userStore.userInfos,
(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => { (keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {
const result = []; const result = [];
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

lib/reducers/user-reducer.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: ( const baseLastCommunicatedPlatformDetailsSelector: (
state: AppState, keyserverID: string,
) => ?PlatformDetails = (state: AppState) => ) => (state: AppState) => ?PlatformDetails = keyserverID => (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID] state.keyserverStore.keyserverInfos[keyserverID]
?.lastCommunicatedPlatformDetails; ?.lastCommunicatedPlatformDetails;
const lastCommunicatedPlatformDetailsSelector: (
keyserverID: string,
) => (state: AppState) => ?PlatformDetails = _memoize(
baseLastCommunicatedPlatformDetailsSelector,
);
const selectedKeyserversSelector: ( const selectedKeyserversSelector: (
state: AppState, state: AppState,
) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector( ) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(
(state: AppState) => state.keyserverStore.keyserverInfos, (state: AppState) => state.keyserverStore.keyserverInfos,
(state: AppState) => state.userStore.userInfos, (state: AppState) => state.userStore.userInfos,
(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => { (keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {
const result = []; const result = [];
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

lib/utils/objects.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: ( const baseLastCommunicatedPlatformDetailsSelector: (
state: AppState, keyserverID: string,
) => ?PlatformDetails = (state: AppState) => ) => (state: AppState) => ?PlatformDetails = keyserverID => (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID] state.keyserverStore.keyserverInfos[keyserverID]
?.lastCommunicatedPlatformDetails; ?.lastCommunicatedPlatformDetails;
const lastCommunicatedPlatformDetailsSelector: (
keyserverID: string,
) => (state: AppState) => ?PlatformDetails = _memoize(
baseLastCommunicatedPlatformDetailsSelector,
);
const selectedKeyserversSelector: ( const selectedKeyserversSelector: (
state: AppState, state: AppState,
) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector( ) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(
(state: AppState) => state.keyserverStore.keyserverInfos, (state: AppState) => state.keyserverStore.keyserverInfos,
(state: AppState) => state.userStore.userInfos, (state: AppState) => state.userStore.userInfos,
(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => { (keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {
const result = []; const result = [];
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

native/redux/redux-debug-utils.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: ( const baseLastCommunicatedPlatformDetailsSelector: (
state: AppState, keyserverID: string,
) => ?PlatformDetails = (state: AppState) => ) => (state: AppState) => ?PlatformDetails = keyserverID => (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID] state.keyserverStore.keyserverInfos[keyserverID]
?.lastCommunicatedPlatformDetails; ?.lastCommunicatedPlatformDetails;
const lastCommunicatedPlatformDetailsSelector: (
keyserverID: string,
) => (state: AppState) => ?PlatformDetails = _memoize(
baseLastCommunicatedPlatformDetailsSelector,
);
const selectedKeyserversSelector: ( const selectedKeyserversSelector: (
state: AppState, state: AppState,
) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector( ) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(
(state: AppState) => state.keyserverStore.keyserverInfos, (state: AppState) => state.keyserverStore.keyserverInfos,
(state: AppState) => state.userStore.userInfos, (state: AppState) => state.userStore.userInfos,
(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => { (keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {
const result = []; const result = [];
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/redux-debug-utils.js

Loading...
View Options

web/redux/redux-setup.js

Loading...