Page MenuHomePhabricator
Differential D9904

[SQLite] add methods to operate on users table
ClosedPublic
Actions

Authored by kamil on Nov 15 2023, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:30 AM
Unknown Object (File)
Tue, Dec 31, 6:22 AM
Unknown Object (File)
Mon, Dec 16, 5:59 PM
Unknown Object (File)
Tue, Dec 10, 11:36 AM
Unknown Object (File)
Nov 30 2024, 3:29 AM
Unknown Object (File)
Nov 24 2024, 7:31 PM
Unknown Object (File)
Nov 8 2024, 2:42 AM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table
Summary
  1. Representation of data row.
  2. Methods to modify table.
  3. Emscripten bindings

Depends on D9903

Test Plan

Tests in D9909

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 15 2023, 12:28 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 15 2023, 12:28 PM
Harbormaster completed remote builds in B24182: Diff 33300.Nov 15 2023, 3:52 PM
kamil updated this revision to Diff 33324.Nov 16 2023, 6:13 AM

refactor

kamil added a child revision: D9909: [SQLite] add functions to convert user data and tests to user store methods.Nov 16 2023, 6:16 AM
Harbormaster completed remote builds in B24199: Diff 33324.Nov 16 2023, 6:44 AM
kamil published this revision for review.Nov 16 2023, 7:06 AM
kamil added inline comments.
lib/ops/user-store-ops.js
30 ↗(On Diff #33324)

as described in D9903, implementing key-value table

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
66–69 ↗(On Diff #33324)

JS spec is here: D9796

kamil edited the summary of this revision. (Show Details)Nov 16 2023, 7:06 AM
kamil edited the test plan for this revision. (Show Details)
tomek accepted this revision.Nov 17 2023, 7:12 AM
tomek added inline comments.
lib/ops/user-store-ops.js
30 ↗(On Diff #33324)

Can we modify this type in a diff that introduces it?

web/cpp/SQLiteQueryExecutorBindings.cpp
19 ↗(On Diff #33324)

Why is it WebUserInfo instead of just UserInfo

This revision is now accepted and ready to land.Nov 17 2023, 7:12 AM
kamil updated this revision to Diff 33403.Nov 20 2023, 3:34 AM

WebUserInfo -> UserInfo

lib/ops/user-store-ops.js
30 ↗(On Diff #33324)

this diff is already landed: D9796

web/cpp/SQLiteQueryExecutorBindings.cpp
19 ↗(On Diff #33324)

leftover from testing, thanks for catching

Harbormaster completed remote builds in B24265: Diff 33403.Nov 20 2023, 3:53 AM
Closed by commit rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table.

Revision Contents
Changeset List

PathSize
lib/
ops/
4 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
5 lines
5 lines
25 lines
entities/
12 lines
web/
cpp/
9 lines
database/
_generated/
types/
6 lines

Diff 33420

View Options

lib/ops/user-store-ops.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/UserInfo.h

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/database/_generated/comm-query-executor.js

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...
View Options

web/database/types/sqlite-query-executor.js

Loading...