Page MenuHomePhabricator
Differential D9914

[native] read users from SQLite on app start
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 6:43 AM.
Tags
None
Referenced Files
F3696280: D9914.diff
Tue, Jan 7, 11:51 AM
Unknown Object (File)
Sun, Jan 5, 8:17 AM
Unknown Object (File)
Sun, Jan 5, 4:25 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:31 AM
Unknown Object (File)
Tue, Dec 31, 6:30 AM
View All 99 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM11d86ef080fd: [native] read users from SQLite on app start
Summary

Get data from DB and populate store.

Only native, web is in progress and those changes shouldn't affect anything.

Depends on D9913

Test Plan

Test if contents are the same

Diff Detail

Repository
rCOMM Comm
Branch
user-store-work-final
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 16 2023, 6:43 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 6:43 AM
Harbormaster failed remote builds in B24205: Diff 33330!Nov 16 2023, 7:33 AM
kamil updated this revision to Diff 33346.Nov 16 2023, 8:24 AM

rebase

kamil published this revision for review.Nov 16 2023, 9:43 AM
Harbormaster failed remote builds in B24213: Diff 33346!Nov 16 2023, 9:46 AM
Harbormaster completed remote builds in B24213: Diff 33346.Nov 16 2023, 10:06 AM
tomek accepted this revision.Nov 17 2023, 7:58 AM
tomek added inline comments.
lib/reducers/user-reducer.js
401–407 ↗(On Diff #33346)

Maybe add a comment that we're going to return users from the payload after we confirm that the solution works correctly.

This revision is now accepted and ready to land.Nov 17 2023, 7:58 AM
kamil updated this revision to Diff 33405.Nov 20 2023, 4:07 AM

add comment

Harbormaster completed remote builds in B24267: Diff 33405.Nov 20 2023, 4:26 AM
Closed by commit rCOMM11d86ef080fd: [native] read users from SQLite on app start (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM11d86ef080fd: [native] read users from SQLite on app start.

Revision Contents
Changeset List

PathSize
lib/
reducers/
1 line
12 lines
types/
3 lines
native/
data/
13 lines

Diff 33330

View Options

lib/reducers/message-reducer.test.js

Loading...
View Options

lib/reducers/user-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...