Page MenuHomePhabricator
Differential D9910

[SQLite] implement C++ user store ops
ClosedPublic
Actions

Authored by kamil on Nov 16 2023, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 8:12 PM
Unknown Object (File)
Sat, Apr 19, 12:05 PM
Unknown Object (File)
Sat, Apr 19, 3:48 AM
Unknown Object (File)
Fri, Apr 18, 7:45 AM
Unknown Object (File)
Fri, Apr 18, 3:12 AM
Unknown Object (File)
Thu, Apr 17, 7:51 PM
Unknown Object (File)
Sun, Apr 6, 6:24 AM
Unknown Object (File)
Mar 17 2025, 8:07 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMa5c95cab2250: [SQLite] implement C++ user store ops
Summary

Code for native ops

Depends on D9909

Test Plan

Code for testing:

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '1',
      userInfo: 'fdfd',
    },
  },
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'replace_user',
    payload: {
      id: '2',
      userInfo: 'fdfd',
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_users',
    payload: {
      ids: ['1'],
    },
  },
]);

await commCoreModule.processUserStoreOperations([
  {
    type: 'remove_all_users',
  },
]);

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 16 2023, 6:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 16 2023, 6:32 AM
kamil added a child revision: D9911: [SQLite] implement C++ code to get users.Nov 16 2023, 6:35 AM
Harbormaster failed remote builds in B24201: Diff 33326!Nov 16 2023, 7:19 AM
kamil updated this revision to Diff 33340.Nov 16 2023, 7:33 AM

typo

Harbormaster failed remote builds in B24207: Diff 33340!Nov 16 2023, 7:45 AM
kamil updated this revision to Diff 33342.Nov 16 2023, 8:21 AM

rebase

Harbormaster completed remote builds in B24209: Diff 33342.Nov 16 2023, 8:48 AM
kamil published this revision for review.Nov 16 2023, 9:12 AM
tomek accepted this revision.Nov 17 2023, 7:46 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20

Is it intentional to return an empty array? Is it implemented later in the stack?

This revision is now accepted and ready to land.Nov 17 2023, 7:46 AM
kamil added inline comments.Nov 20 2023, 4:03 AM
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp
19–20

it's implemented in next diff: D9911

Closed by commit rCOMMa5c95cab2250: [SQLite] implement C++ user store ops (authored by kamil). · Explain WhyNov 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa5c95cab2250: [SQLite] implement C++ user store ops.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
3 lines
4 lines
9 lines
PersistentStorageUtilities/
DataStores/
29 lines
62 lines
47 lines
_generated/
ios/
Comm.xcodeproj/
8 lines
schema/
4 lines

Diff 33342

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.h

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/UserStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...