Paths

Table of Contentst

Differential D9816

[lib] Inline reduceDeviceToken
ClosedPublic
Actions

Authored by inka on Nov 10 2023, 4:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 7:27 PM

	Unknown Object (File)
	Wed, Nov 6, 7:27 PM

	Unknown Object (File)
	Wed, Nov 6, 7:26 PM

	Unknown Object (File)
	Wed, Nov 6, 7:26 PM

	Unknown Object (File)
	Wed, Nov 6, 7:26 PM

	Unknown Object (File)
	Wed, Nov 6, 7:26 PM

	Unknown Object (File)
	Wed, Nov 6, 7:19 PM

	Unknown Object (File)
	Oct 17 2024, 10:24 AM

View All 89 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM0dafbd55dc7b: [lib] Inline reduceDeviceToken

Summary

issue: https://linear.app/comm/issue/ENG-5652/inline-reducedevicetoken
See the deleted file for how it worked before

Test Plan

Dispatched incrementalStateSyncActionType, setDeviceTokenActionTypes actions, chcked that the state changes as expected

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Nov 10 2023, 4:27 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 4:27 AM

inka added a parent revision: D9815: [lib] Inline reduceConnectionInfo pt.2.Nov 10 2023, 4:27 AM

Harbormaster completed remote builds in B23988: Diff 33057.Nov 10 2023, 4:45 AM

inka requested review of this revision.Nov 10 2023, 4:45 AM

inka added a child revision: D9820: [lib] Refactor keyserver reducer pt.2 - early return.Nov 10 2023, 6:14 AM

Rebase

Harbormaster completed remote builds in B24103: Diff 33203.Nov 14 2023, 1:54 AM

michal accepted this revision.Nov 14 2023, 6:11 AM

michal added inline comments.

lib/reducers/keyserver-reducer.js
330	Nit: does this work?

This revision is now accepted and ready to land.Nov 14 2023, 6:11 AM

inka added inline comments.Nov 14 2023, 7:13 AM

lib/reducers/keyserver-reducer.js
330	No. This is a trick to strip `KeyserverInfos` of read-only on fileds, so that we can do the assignment in line 332. Otherwise we get a flow error: Cannot assign object literal to `keyserverInfos[keyserverID]` because an index signature declaring the expected key / value type is not writable.Flow(cannot-write)

Rebase

Harbormaster completed remote builds in B24193: Diff 33316.Nov 16 2023, 2:02 AM

ashoat added inline comments.Nov 16 2023, 5:48 AM

lib/reducers/keyserver-reducer.js
137 ↗	(On Diff #33316)	Nit: shorthand

Address review

Harbormaster completed remote builds in B24273: Diff 33411.Nov 20 2023, 5:38 AM

Closed by commit rCOMM0dafbd55dc7b: [lib] Inline reduceDeviceToken (authored by inka). · Explain WhyNov 22 2023, 7:24 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0dafbd55dc7b: [lib] Inline reduceDeviceToken.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

device-token-reducer.js

keyserver-reducer.js

44 lines

Diff 33203

lib/reducers/device-token-reducer.js

Loading...

lib/reducers/keyserver-reducer.js

Loading...