Page MenuHomePhabricator
Differential D9817

Add encryption order to encrypted notifications
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 6:19 AM
Unknown Object (File)
Mon, Nov 18, 2:09 PM
Unknown Object (File)
Mon, Nov 11, 1:41 PM
Unknown Object (File)
Thu, Oct 31, 6:33 AM
Unknown Object (File)
Tue, Oct 29, 10:40 AM
Unknown Object (File)
Tue, Oct 29, 7:46 AM
Unknown Object (File)
Tue, Oct 29, 7:36 AM
Unknown Object (File)
Tue, Oct 29, 7:36 AM
View All Files
Subscribers
ashoat
will

Details

Reviewers
kamil
michal
tomek
Commits
rCOMM923990a49ce8: Add encryption order to encrypted notifications
Summary

This differential add encryptionOrder field to result of encryption with olm session, which contains information about encryption ordering.

Test Plan

edit in web GUI

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 10 2023, 5:41 AM
Herald added subscribers: will, ashoat. · View Herald TranscriptNov 10 2023, 5:41 AM
Harbormaster completed remote builds in B23989: Diff 33063.Nov 10 2023, 6:01 AM
marcin requested review of this revision.Nov 10 2023, 6:01 AM
marcin updated this revision to Diff 33066.Nov 10 2023, 6:07 AM

rebase to update commit message

marcin added a parent revision: D9661: Decrypt encrypted web notifications in service worker.Nov 10 2023, 6:08 AM
marcin added a child revision: D9818: Refactor Windows push code to match conventions for other platforms.
Harbormaster completed remote builds in B23992: Diff 33066.Nov 10 2023, 6:38 AM
tomek accepted this revision.Nov 13 2023, 7:25 AM
tomek added inline comments.
keyserver/src/push/crypto.js
30 ↗(On Diff #33066)

Why is it optional?

This revision is now accepted and ready to land.Nov 13 2023, 7:25 AM
marcin added inline comments.Nov 13 2023, 8:25 AM
keyserver/src/push/crypto.js
30 ↗(On Diff #33066)

It is kept optional to handle the case of encryption failure, when ee can't assign it a meaningful value

marcin updated this revision to Diff 33544.Nov 23 2023, 2:07 AM

Rebase before landing

Harbormaster completed remote builds in B24364: Diff 33544.Nov 23 2023, 4:12 AM
Closed by commit rCOMM923990a49ce8: Add encryption order to encrypted notifications (authored by marcin). · Explain WhyNov 23 2023, 5:50 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM923990a49ce8: Add encryption order to encrypted notifications.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
32 lines
1 line
3 lines
updaters/
3 lines

Diff 33544

View Options

keyserver/src/push/crypto.js

Loading...
View Options

keyserver/src/push/rescind.js

Loading...
View Options

keyserver/src/push/types.js

Loading...
View Options

keyserver/src/updaters/olm-session-updater.js

Loading...