[lib] Add function for finding the time of the newest message per keyserver
ClosedPublic
Actions

Authored by inka on Nov 14 2023, 6:01 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMMe5cb30a87371: [lib] Add function for finding the time of the newest message per keyserver

Summary

issue: https://linear.app/comm/issue/ENG-5723/update-mergenewmessages-function
I need a function that for an array of messages will give me the time of the newest message for every keyserver

Test Plan

Ran the provided test

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 14 2023, 6:01 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 6:02 AM

inka added a parent revision: D9879: [keyserver][lib] Update freshMessageStore to return currentAsOf for all keyservers.Nov 14 2023, 6:02 AM

Harbormaster completed remote builds in B24107: Diff 33207.Nov 14 2023, 6:20 AM

inka requested review of this revision.Nov 14 2023, 6:20 AM

inka added a child revision: D9882: [lib] Calculate currentAsOf for every keyserver in mergeNewMessages.Nov 14 2023, 6:32 AM

michal accepted this revision.Nov 14 2023, 7:05 AM

This revision is now accepted and ready to land.Nov 14 2023, 7:05 AM

Closed by commit rCOMMe5cb30a87371: [lib] Add function for finding the time of the newest message per keyserver (authored by inka). · Explain WhyNov 22 2023, 7:24 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe5cb30a87371: [lib] Add function for finding the time of the newest message per keyserver.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

21 lines

message-utils.test.js

44 lines

Diff 33509

View Options

lib/shared/message-utils.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };