Page MenuHomePhabricator

[services] Blob - Fix logic for primary key
ClosedPublic

Authored by karol on Feb 11 2022, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 13, 6:09 PM
Unknown Object (File)
Sun, Oct 13, 6:09 PM
Unknown Object (File)
Sun, Oct 13, 6:08 PM
Unknown Object (File)
Sun, Oct 13, 6:08 PM
Unknown Object (File)
Sun, Oct 13, 6:00 PM
Unknown Object (File)
Thu, Oct 10, 10:13 AM
Unknown Object (File)
Sep 28 2024, 8:06 PM
Unknown Object (File)
Sep 20 2024, 5:49 AM

Details

Summary

We want to apply the changes from D3177 to all services.

I'm not sure what's the state of the tunnelbroker service so I created a task for it for now https://linear.app/comm/issue/ENG-728/fix-primary-key-logic-for-tunnelbroker

Depends on D3178

Test Plan
cd services
yarn test-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, max, varun.
tomek requested changes to this revision.Feb 11 2022, 7:56 AM

The comments I added in previous diffs in this stack also apply here, so I'll request changes

This revision now requires changes to proceed.Feb 11 2022, 7:56 AM

I'm going to wait for a review for D3177 D3178 and apply changes here accordingly then.

This revision is now accepted and ready to land.Feb 16 2022, 5:25 AM
This revision now requires review to proceed.Feb 16 2022, 5:25 AM
This revision is now accepted and ready to land.Feb 21 2022, 11:53 PM