Page MenuHomePhabricator

[web] Export navigation tab types
ClosedPublic

Authored by tomek on Mar 4 2022, 8:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 8:57 AM
Unknown Object (File)
Wed, Dec 18, 2:21 PM
Unknown Object (File)
Wed, Dec 18, 1:01 PM
Unknown Object (File)
Wed, Dec 18, 12:59 PM
Unknown Object (File)
Wed, Dec 18, 11:09 AM
Unknown Object (File)
Thu, Dec 12, 3:12 AM
Unknown Object (File)
Sun, Dec 8, 7:54 AM
Unknown Object (File)
Nov 3 2024, 1:22 PM

Details

Summary

These will be used in a couple of places
Depends on D3339
Depends on D3336

Test Plan

Just check if opening chat and calendar still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Mar 4 2022, 8:24 AM

This makes sense. Curious if we should follow a similar pattern that we have in native: https://github.com/CommE2E/comm/blob/master/lib/types/account-types.js

This _seems_ similar but also I'm cautious to say one-way-or-another because we don't use the correct (documented) routing system of react-router.

This revision is now accepted and ready to land.Mar 7 2022, 6:59 AM

This makes sense. Curious if we should follow a similar pattern that we have in native: https://github.com/CommE2E/comm/blob/master/lib/types/account-types.js

This _seems_ similar but also I'm cautious to say one-way-or-another because we don't use the correct (documented) routing system of react-router.

What do you mean by similar pattern? Are you suggesting that we should put these in lib and use on both native and web? If that's the case, I'm not sure it is a good idea, because it is likely that our navigation structure will be different on different platforms. (usually native experiences consist of more screens because there's less place for the content)

This revision was automatically updated to reflect the committed changes.