Page MenuHomePhabricator
Differential D3342

[web] Introduce settings switcher
ClosedPublic
Actions

Authored by tomek on Mar 4 2022, 9:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 3:05 AM
Unknown Object (File)
Thu, Nov 14, 8:50 AM
Unknown Object (File)
Fri, Nov 8, 12:41 PM
Unknown Object (File)
Sun, Oct 27, 9:00 AM
Unknown Object (File)
Oct 1 2024, 8:11 PM
Unknown Object (File)
Sep 27 2024, 1:58 PM
Unknown Object (File)
Sep 27 2024, 1:58 PM
Unknown Object (File)
Sep 27 2024, 1:58 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• benschac
atul
• jacek
Commits
rCOMM3a0e3af77fba: [web] Introduce settings switcher
Summary

Render the first option from the switcher, currently not interactive
Depends on D3341

Test Plan

Render the component instead of AppSwitcher and check if it is displayed correctly. Manually switch between calendar and settings/account routes and check if the navigation option was highlighted only in the 2nd case

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Mar 4 2022, 9:08 AM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 4 2022, 9:08 AM
Harbormaster completed remote builds in B7158: Diff 10084.Mar 4 2022, 9:13 AM
tomek requested review of this revision.Mar 4 2022, 9:13 AM
tomek added a child revision: D3343: [web] Navigate to the settings on click.Mar 4 2022, 9:18 AM
• benschac accepted this revision.Mar 7 2022, 6:37 AM
This revision is now accepted and ready to land.Mar 7 2022, 6:37 AM
atul accepted this revision.Mar 8 2022, 8:26 AM
tomek planned changes to this revision.Mar 9 2022, 10:01 AM

This and following diffs from the stack need to be rebased to use the new approach

tomek edited parent revisions, added: D3388: [web] Address remaining code review comments from D3341; removed: D3341: [web] Make NavigationPanel reusable.Mar 11 2022, 1:43 AM
tomek updated this revision to Diff 10293.Mar 11 2022, 3:56 AM
tomek added a parent revision: D3341: [web] Make NavigationPanel reusable.

Use NavigationPanel.Item

This revision is now accepted and ready to land.Mar 11 2022, 3:56 AM
Harbormaster completed remote builds in B7299: Diff 10293.Mar 11 2022, 4:01 AM
Closed by commit rCOMM3a0e3af77fba: [web] Introduce settings switcher (authored by tomek). · Explain WhyMar 11 2022, 4:05 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3a0e3af77fba: [web] Introduce settings switcher.
rohan mentioned this in D8818: [lib/web] Route to a barebones QR code login page.Aug 15 2023, 10:11 AM
rohan mentioned this in rCOMMe399279d27eb: [lib/web] Route to a barebones QR code login page.Aug 17 2023, 12:50 PM

Revision Contents
Changeset List

PathSize
web/
sidebar/
26 lines

Diff 10293

View Options

web/sidebar/settings-switcher.react.js

Loading...