Page MenuHomePhabricator

[services][draft] Blob refactor to async API - Put
AbandonedPublic

Authored by karol on Mar 14 2022, 7:19 AM.
Tags
None
Referenced Files
F3355374: D3415.id10332.diff
Sat, Nov 23, 2:25 PM
Unknown Object (File)
Fri, Nov 8, 10:55 AM
Unknown Object (File)
Wed, Nov 6, 11:37 AM
Unknown Object (File)
Tue, Nov 5, 6:25 PM
Unknown Object (File)
Oct 17 2024, 1:08 PM
Unknown Object (File)
Oct 17 2024, 12:44 PM
Unknown Object (File)
Oct 17 2024, 12:42 PM
Unknown Object (File)
Oct 17 2024, 12:39 PM

Details

Summary

Depends on D3248

Put operation in the blob service refactored from sync to async api.

Test Plan
cd services
yarn run-blob-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 14 2022, 7:20 AM
Harbormaster failed remote builds in B7325: Diff 10326!
karol retitled this revision from [services] Blob - Put to [services][draft] Blob refactor to async API - Put.Mar 14 2022, 7:24 AM
karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)
karol added reviewers: tomek, max, varun, jim.
tomek requested changes to this revision.EditedMar 16 2022, 9:53 AM

This code is really hard to read. The logic there is a dense complicated block of code, which would take a lot of time for anyone to read and understand. Could you spend some time refactoring it into e.g. functions (with descriptive names and clearly defined scope)? Or at least, think through this code, check which parts might be confusing and add long comments explaining what's going on.

I can see that there's a draft label here. I guess we've agreed that we should use drafts only for arch review... but I might be wrong. Nevertheless, what's the difference here between draft and non-draft?

This revision now requires changes to proceed.Mar 16 2022, 9:53 AM

Abandoning, I'm going to put up a new stack for this which will be hopefully easier to review.