Page MenuHomePhabricator
Differential D3668

[web] Remove `Modal`s usused style
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 4:25 AM.
Tags
None
Referenced Files
F3668275: D3668.id11934.diff
Sun, Jan 5, 11:17 PM
F3668274: D3668.id11923.diff
Sun, Jan 5, 11:17 PM
Unknown Object (File)
Wed, Jan 1, 1:44 AM
Unknown Object (File)
Wed, Jan 1, 1:02 AM
Unknown Object (File)
Wed, Jan 1, 1:02 AM
Unknown Object (File)
Wed, Jan 1, 1:02 AM
Unknown Object (File)
Wed, Jan 1, 1:02 AM
Unknown Object (File)
Wed, Jan 1, 1:02 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMM3274d77df84a: [web] Remove `Modal`s usused style
Summary

The style has not been used anywhere in the project

Test Plan

Nothing changes in project

Diff Detail

Repository
rCOMM Comm
Branch
jacek/modal-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Apr 8 2022, 4:25 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 4:25 AM
Harbormaster completed remote builds in B8020: Diff 11225.Apr 8 2022, 4:33 AM
• jacek requested review of this revision.Apr 8 2022, 4:33 AM
• jacek added a child revision: D3669: [web] Redesign `Modal` to match Figma.Apr 8 2022, 6:01 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:06 AM
atul accepted this revision.Apr 8 2022, 10:43 AM

Looks good!

(did a quick search of intro-modal, intro_modal, and introModal in the codebase just in case, and found no occurrences)

This revision is now accepted and ready to land.Apr 8 2022, 10:43 AM
• jacek updated this revision to Diff 11466.Apr 14 2022, 3:09 AM

rebase

Harbormaster completed remote builds in B8195: Diff 11466.Apr 14 2022, 3:14 AM
• jacek updated this revision to Diff 11878.Apr 25 2022, 10:27 AM

rebase

Harbormaster completed remote builds in B8519: Diff 11878.Apr 25 2022, 10:39 AM
• jacek updated this revision to Diff 11923.Apr 26 2022, 8:33 AM

rebase

Harbormaster completed remote builds in B8554: Diff 11923.Apr 26 2022, 8:46 AM
Closed by commit rCOMM3274d77df84a: [web] Remove `Modal`s usused style (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM3274d77df84a: [web] Remove `Modal`s usused style.

Revision Contents
Changeset List

PathSize
web/
modals/
12 lines

Diff 11225

View Options

web/modals/modal.css

Loading...