Page MenuHomePhabricator
Differential D3672

[web] Adjust `SubchannelsModal` size to match designs
ClosedPublic
Actions

Authored by • jacek on Apr 8 2022, 5:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 9:20 PM
Unknown Object (File)
Tue, Apr 1, 2:46 PM
Unknown Object (File)
Tue, Apr 1, 10:55 AM
Unknown Object (File)
Tue, Apr 1, 12:58 AM
Unknown Object (File)
Mon, Mar 31, 6:20 AM
Unknown Object (File)
Mon, Mar 31, 3:54 AM
Unknown Object (File)
Sun, Mar 30, 2:19 PM
Unknown Object (File)
Sun, Mar 30, 4:20 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
tomek
atul
• benschac
Commits
rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs
Summary

Changed SubchannelsModal content size to match design in Figma.

Screenshot_Google Chrome_2022-04-11_084329.png (956×1 px, 139 KB)

Test Plan

Open SubchannelsModal from thread actions menu

Diff Detail

Repository
rCOMM Comm
Branch
jacek/modal-improvements
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Apr 8 2022, 5:59 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 8 2022, 5:59 AM
• jacek added a parent revision: D3670: [web] Allow passing `Modal` parameters into `SearchModal`.Apr 8 2022, 6:01 AM
• jacek added reviewers: tomek, atul, • benschac.Apr 8 2022, 6:08 AM
Harbormaster completed remote builds in B8024: Diff 11229.Apr 8 2022, 6:09 AM
• jacek requested review of this revision.Apr 8 2022, 6:09 AM
atul accepted this revision.Apr 8 2022, 11:22 AM

(see: https://phabricator.ashoat.com/D3671#100936)

This revision is now accepted and ready to land.Apr 8 2022, 11:22 AM
• jacek edited the summary of this revision. (Show Details)Apr 10 2022, 11:44 PM
• jacek added a parent revision: D3669: [web] Redesign `Modal` to match Figma.Apr 22 2022, 3:44 AM
• jacek updated this revision to Diff 11882.Apr 25 2022, 10:29 AM

rebase

Harbormaster completed remote builds in B8523: Diff 11882.Apr 25 2022, 10:47 AM
• jacek updated this revision to Diff 11927.Apr 26 2022, 8:35 AM

rebase

Harbormaster completed remote builds in B8558: Diff 11927.Apr 26 2022, 8:53 AM
Closed by commit rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs (authored by • jacek). · Explain WhyApr 26 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMMd8e2452fd22d: [web] Adjust `SubchannelsModal` size to match designs.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
subchannels/
2 lines
1 line

Diff 11229

View Options

web/modals/threads/subchannels/subchannels-modal.css

Show First 20 Lines • Show All 1,162 Lines • ▼ Show 20 Lines
bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) { bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
return DatabaseManager::checkIfDatabaseNeedsDeletion(); return DatabaseManager::checkIfDatabaseNeedsDeletion();
} }
void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) { void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
DatabaseManager::reportDBOperationsFailure(); DatabaseManager::reportDBOperationsFailure();
} }
jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityGenerateNonce(currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
} // namespace comm } // namespace comm
View Options

web/modals/threads/subchannels/subchannels-modal.react.js

Show First 20 Lines • Show All 1,162 Lines • ▼ Show 20 Lines
bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) { bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
return DatabaseManager::checkIfDatabaseNeedsDeletion(); return DatabaseManager::checkIfDatabaseNeedsDeletion();
} }
void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) { void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
DatabaseManager::reportDBOperationsFailure(); DatabaseManager::reportDBOperationsFailure();
} }
jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityGenerateNonce(currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
} // namespace comm } // namespace comm