Details

Reviewers

• jim
• karol
tomek
atul

Commits

rCOMMe70770673a3b: [Identity] Add config for Identity service

Summary

Depends on D3799

In order to implement PAKE registration/login in the Identity service, we need to persist a secret key and then share that key with the gRPC methods that use it. In this diff I have created a config module to load the key from a file into memory and then shared the key with the gRPC methods by adding a Config struct to MyIdentityService.

Test Plan

Ran the service and tested that the relevant Config was available in MyIdentityService

Diff Detail

Repository

rCOMM Comm

Branch

varun/identity_service (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 21 2022, 12:07 PM

Herald added subscribers: • abosh, • benschac, • adrian, ashoat. · View Herald TranscriptApr 21 2022, 12:07 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 21 2022, 12:10 PM

Harbormaster failed remote builds in B8426: Diff 11758!

varun requested review of this revision.Apr 21 2022, 12:11 PM

varun added 1 blocking reviewer(s): • jim.Apr 21 2022, 1:43 PM

trigger new build after rebase

Harbormaster completed remote builds in B8465: Diff 11804.Apr 22 2022, 7:36 AM

varun added a child revision: D3852: [Identity] Add tracing to the Identity service.Apr 25 2022, 8:47 PM

• jim requested changes to this revision.Apr 26 2022, 9:57 AM

• jim added inline comments.

services/identity/src/config.rs
22 ↗	(On Diff #11804)	This isn't a great way to do error handling -- you're throwing away the type information... I would make a wrapper enum with derive_more. #[derive(Debug, derive_more::Display, derive_more::From, derive_more::Error)] pub enum Error { #[display(...)] Pake(PakeError), #[display(...)] IO(io::Error), }
services/identity/src/main.rs
11 ↗	(On Diff #11804)	Load the config first then, `MyIdentityService::new(config)`
15 ↗	(On Diff #11804)	Why expect? You can just return an err.