Page MenuHomePhabricator

[web] Introduce searching users in `AddMembersModal`
ClosedPublic

Authored by jacek on Apr 15 2022, 4:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 4:24 PM
Unknown Object (File)
Fri, Nov 22, 10:03 PM
Unknown Object (File)
Fri, Nov 22, 5:43 PM
Unknown Object (File)
Thu, Nov 21, 3:19 AM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Fri, Nov 8, 3:33 AM
Unknown Object (File)
Fri, Nov 8, 1:12 AM
Unknown Object (File)
Thu, Nov 7, 10:40 PM

Details

Summary

Add logic responsible for finding users, that can be added (or not) to the thread based on search query. Used getPotentialMemberItems lib function, that is used in native app.

Screenshot_Google Chrome_2022-04-15_135513.png (516×470 px, 27 KB)

Test Plan

The search can be tested after introducing button activating AddMembersModal - search results should be exactly the same as in mobile app for the same query.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
web/modals/threads/members/add-members-modal.react.js
47–57 ↗(On Diff #11513)

This can be simplified a bit

This revision is now accepted and ready to land.Apr 15 2022, 9:35 AM