Paths

Table of Contentst

Differential D3743

[web] Introduce searching users in `AddMembersModal`
ClosedPublic
Actions

Authored by • jacek on Apr 15 2022, 4:38 AM.

Tags

None

Referenced Files

	F3178204: D3743.id11972.diff
	Fri, Nov 8, 1:12 AM

	F3177172: D3743.diff
	Thu, Nov 7, 10:40 PM

	Unknown Object (File)
	Tue, Nov 5, 3:55 AM

	Unknown Object (File)
	Tue, Oct 29, 12:32 PM

	Unknown Object (File)
	Tue, Oct 29, 12:32 PM

	Unknown Object (File)
	Wed, Oct 16, 8:41 AM

	Unknown Object (File)
	Wed, Oct 16, 8:41 AM

	Unknown Object (File)
	Wed, Oct 16, 8:41 AM

Subscribers

Details

Reviewers

tomek
atul
• benschac

Commits

rCOMMac879d198c4c: [web] Introduce searching users in `AddMembersModal`

Summary

Add logic responsible for finding users, that can be added (or not) to the thread based on search query. Used getPotentialMemberItems lib function, that is used in native app.

Screenshot_Google Chrome_2022-04-15_135513.png (516×470 px, 27 KB)

Test Plan

The search can be tested after introducing button activating AddMembersModal - search results should be exactly the same as in mobile app for the same query.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 15 2022, 4:38 AM

Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 15 2022, 4:38 AM

• jacek edited the summary of this revision. (Show Details)Apr 15 2022, 4:56 AM

• jacek edited the test plan for this revision. (Show Details)

• jacek added reviewers: tomek, atul, • benschac.

• jacek added a child revision: D3744: [web] Add callback adding members to thread in `AddMembersModal`.

• jacek added a parent revision: D3742: [web] Introduce `AddMembersModal` component.

Harbormaster completed remote builds in B8229: Diff 11513.Apr 15 2022, 8:29 AM

• jacek requested review of this revision.Apr 15 2022, 8:29 AM

tomek accepted this revision.Apr 15 2022, 9:35 AM

tomek added inline comments.

web/modals/threads/members/add-members-modal.react.js
47–57 ↗	(On Diff #11513)	This can be simplified a bit

This revision is now accepted and ready to land.Apr 15 2022, 9:35 AM

Simplify memo & rebase

Harbormaster completed remote builds in B8590: Diff 11972.Apr 27 2022, 2:45 AM

rebase

Harbormaster completed remote builds in B8691: Diff 12102.Apr 29 2022, 3:32 AM

Closed by commit rCOMMac879d198c4c: [web] Introduce searching users in `AddMembersModal` (authored by • jacek). · Explain WhyApr 29 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMac879d198c4c: [web] Introduce searching users in `AddMembersModal`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

add-members-modal.react.js

48 lines

Diff 12108

web/modals/threads/members/add-members-modal.react.js

Loading...