We should close the modal only after successful update. We can consider keeping the modal open and closing the tags, but we definitely must not close the modal before the response is received.
Depends on D4314
Details
Details
- Reviewers
• jacek atul ashoat - Commits
- rCOMM5c91ef833765: [web] Handle relationship update errors
Modify relationship responder so that every second request succeeds. Select a user and click confirm button - the modal should remain open and the button should be disabled until the response is received. After the response, click the button again - the modal should get closed and the user should appear on friends list.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ENG-1142
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
(Reading through action-utils right now to better understand what's going on with dispatchActionPromise(...) and co ... adding @ashoat as a reviewer in the meanwhile if he gets to it first + it's probably good to get a second pair of eyes on it)
Comment Actions
Looks good!
| web/settings/relationship/add-users-list.react.js | ||
|---|---|---|
| 189–194 | Should we do what we do (for example) in thread-settings-general-tab.react.js:changeThreadSettingsAction and wrap the call to callUpdateRelationships in a try/catch? Then we can gracefully display any errors and nudge to user to retry or whatever | |