Page MenuHomePhabricator
Differential D4164

[services] Tests - Add backup utils
ClosedPublic
Actions

Authored by • karol on May 31 2022, 6:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 6:39 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
Unknown Object (File)
Thu, Nov 14, 4:42 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
ashoat
Commits
rCOMM1601aef2026a: [services] Tests - Add backup utils
Summary

Depends on D4161

I'm not an expert at all in Rust crate/module system. I decided to create a separate module that's going to be fetching all necessary things and then multiple modules can take that imports from here.

Test Plan

This itself doesn't do anything.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 31 2022, 6:50 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 31 2022, 6:50 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 6:55 AM
Harbormaster failed remote builds in B9543: Diff 13237!
• karol requested review of this revision.May 31 2022, 7:07 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, ashoat, varun.
• karol added a parent revision: D4163: [DRAFT] [services] Tests - Add to docker compose.

ios failed, unrelated.

• karol added a child revision: D4165: [services] Tests - Add create new backup.May 31 2022, 7:09 AM
• karol updated this revision to Diff 13244.May 31 2022, 7:19 AM

CI

Harbormaster failed remote builds in B9550: Diff 13244!May 31 2022, 7:22 AM
• karol updated this revision to Diff 13249.May 31 2022, 7:25 AM

CI

Harbormaster failed remote builds in B9555: Diff 13249!May 31 2022, 7:26 AM
• karol planned changes to this revision.May 31 2022, 7:33 AM
• karol requested review of this revision.May 31 2022, 7:44 AM

I know that Ci failed but it's related to docker which I know is not working properly right now.

ashoat resigned from this revision.May 31 2022, 1:05 PM

I don't feel confident enough to review Rust :(

varun accepted this revision.Jun 1 2022, 9:48 AM

Do these all need to be pub?

This revision is now accepted and ready to land.Jun 1 2022, 9:48 AM
• karol added inline comments.Jun 6 2022, 4:56 AM
services/commtest/src/backup_utils.rs
1–5 ↗(On Diff #13249)

Answering Varun's comment: these two have to be public

7–16 ↗(On Diff #13249)

turns out this is redundant

• karol updated this revision to Diff 13361.Jun 6 2022, 4:59 AM

remove redundant imports

Harbormaster completed remote builds in B9639: Diff 13361.Jun 6 2022, 5:08 AM
tomek accepted this revision.Jun 7 2022, 1:48 AM
• karol added a child revision: D4224: [DRAFT] [services] Tests - Backup Utils - Add BackupData struct.Jun 7 2022, 7:38 AM
• karol removed a child revision: D4165: [services] Tests - Add create new backup.Jun 7 2022, 8:37 AM
• karol requested review of this revision.Jun 8 2022, 12:52 AM
• karol retitled this revision from [DRAFT] [services] Tests - Add backup utils to [services] Tests - Add backup utils.

Accepted as a draft, so removing the draft label and requesting review - I know this diff is simple but I'm doing it just for the rules' sake.

tomek accepted this revision.Jun 8 2022, 2:06 AM
This revision is now accepted and ready to land.Jun 8 2022, 2:06 AM
• karol removed a parent revision: D4163: [DRAFT] [services] Tests - Add to docker compose.Jun 13 2022, 4:39 AM
• karol edited the summary of this revision. (Show Details)
• karol added a parent revision: D4161: [services] Tests - Initialize project.
• karol added a child revision: D4225: [services] Tests - Add tools.Jun 13 2022, 4:51 AM
• karol removed a child revision: D4224: [DRAFT] [services] Tests - Backup Utils - Add BackupData struct.
• karol updated this revision to Diff 13458.Jun 13 2022, 6:45 AM

new stack

Harbormaster completed remote builds in B9713: Diff 13458.Jun 13 2022, 6:54 AM
varun added inline comments.Jun 15 2022, 11:15 AM
services/commtest/tests/backup/backup_utils.rs
23 ↗(On Diff #13458)
24–25 ↗(On Diff #13458)
• karol updated this revision to Diff 13595.Jun 20 2022, 3:26 AM

obj asssignment shorter

Harbormaster completed remote builds in B9831: Diff 13595.Jun 20 2022, 3:39 AM
Closed by commit rCOMM1601aef2026a: [services] Tests - Add backup utils (authored by • karol). · Explain WhyJun 27 2022, 4:21 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM1601aef2026a: [services] Tests - Add backup utils.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
36 lines

Diff 13823

View Options

services/commtest/tests/backup/backup_utils.rs

Loading...