Page MenuHomePhabricator
Differential D4530

[keyserver] Cast NULLs in UNION SELECT
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 6:50 PM.
Tags
None
Referenced Files
F3387620: D4530.id.diff
Fri, Nov 29, 10:25 AM
Unknown Object (File)
Tue, Nov 26, 10:19 PM
Unknown Object (File)
Tue, Nov 26, 1:35 PM
Unknown Object (File)
Tue, Nov 26, 5:24 AM
Unknown Object (File)
Sat, Nov 16, 9:59 AM
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Oct 18 2024, 4:21 AM
Unknown Object (File)
Oct 7 2024, 11:44 AM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
• jon
atul
tomek
Commits
rCOMMac199c492c82: [keyserver] Cast NULLs in UNION SELECT
Summary

See comment on Linear. This fixes a bug where we were seeing strings where we previously saw numbers.

Depends on D4528

Test Plan
  1. I made sure the syntax was valid on both MySQL 5.7 and MariaDB 10.8 based on docs
  2. I tested with MariaDB 10.8
  3. I made sure the issue only occured when merging in NULL in cases where you aren't expecting a string by testing queries
  4. I git grepd through the codebase to make sure this was the only place we were doing that

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/mariadb
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 13 2022, 6:50 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 6:50 PM
ashoat added a child revision: D4531: [keyserver] Update mysql2 to 2.3.3.Jul 13 2022, 6:52 PM
Harbormaster completed remote builds in B10505: Diff 14453.Jul 13 2022, 7:03 PM
ashoat requested review of this revision.Jul 13 2022, 7:03 PM
atul accepted this revision.Jul 14 2022, 9:51 AM

Looks good, testing our DB queries to make sure output is held constant would probably be good to do someday

This revision is now accepted and ready to land.Jul 14 2022, 9:51 AM
Closed by commit rCOMMac199c492c82: [keyserver] Cast NULLs in UNION SELECT (authored by ashoat). · Explain WhyJul 17 2022, 8:14 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMac199c492c82: [keyserver] Cast NULLs in UNION SELECT.
ashoat added a comment.Jul 18 2022, 9:09 AM

This diff broke MySQL: https://linear.app/comm/issue/ENG-1409/relationship-prompt-appears-even-if-users-are-already-friends

ashoat mentioned this in D4558: [keyserver] Fix fetchKnownUserInfos.Jul 18 2022, 11:45 AM
ashoat mentioned this in rCOMM69b3a66efe71: [keyserver] Fix fetchKnownUserInfos.Jul 18 2022, 2:25 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
7 lines

Diff 14453

View Options

keyserver/src/fetchers/user-fetchers.js

Loading...