This was the only reasonable place I found for now. I figured once we start using the services there will be some subfolder handling communication with them, and this code could then probably be moved there. I could create such a subfolder now, but it seemed like an overkill, and I don't really know where it will need to be placed.

Since regex follows semver, "1" would be correct in the version range. But upstream seems to recommend a major minor version.

https://crates.io/crates/regex

Could use something like https://github.com/BurntSushi/quickcheck to dynamically generate input.

I don't understand what exactly you want to generate... We have three possible values of the input so...

In D4587 I gave the same name to an 'enum' on web, so I'll create a new diff changing these names

Normally the output of test that have passed is captured anyway. To see the output of non-failed tests we need to explicitly run cargo test -- --nocapture.

I know I could have extracted that as well, but I think it's more clear if test phases (preparation (nothing to do in this case), execution, assertion) are more or less visible in the test itself.

Why not just call Alphanumeric.sample_string()?

Example here: https://github.com/CommE2E/comm/blob/master/services/identity/src/token.rs#L35

I couldn't find a nice way of using DEVICE_ID_CHAR_LENGTH for defining this regex (I mean sth like "^(ks|mobile|web):[a-zA-Z0-9]{${DEVICE_ID_CHAR_LENGTH}}$"). The best way I found is using const_format create, but I'm not sure we want do introduce another dependency for something like this...

-inka

If we can separate stuff related to tests from application code then I think we should do so.

-Marcin

Originally this was in mod tests, but because of the need to keep this in sync with other files (as explained in the comment above the constant) I've put these constants that relate to some application logic next to each other, like in the other files. In rust code this is just related to tests, but in other places this regex is actually used. Eg. in services/tunnelbroker/src/Tools/Tools.cpp DEVICEID_FORMAT_REGEX from services/tunnelbroker/src/Constants.h is used validate device id passed to tunnelbroker.
I'm open to changing this if you still think it's best, just wanted to explain why I moved it.

-inka

Declaration outside of extern "Rust" scope is essential here since C++ would not be able to understand this type. Context is here: https://cxx.rs/shared.html. I am leaving this comment in case future reviewers get confused here.

-Marcin

I am not requesting it but in my opinion it would be nice to use some source of separation here like a comment line: //crypto_tools or something. Unfortunately we cannot create separate module for each function set we want to generate C++ bindings for, so we could at least provide "logical" separation with comments.

-Marcin, before // Crypto Tools was added

Because we are using cxx we now need a wildcard for the enum. Context: cxx.rs/shared

I looked into it and I think we actually don't need this, sorry

I renamed the variable whose only characteristic in this context is being a string to s based on function declarations in std::string::String