Page MenuHomePhabricator
Differential D4994

[Android] Update reference to protobuf files
ClosedPublic
Actions

Authored by • jon on Aug 31 2022, 10:32 AM.
Tags
None
Referenced Files
F3245588: D4994.id16507.diff
Thu, Nov 14, 7:31 PM
Unknown Object (File)
Sat, Oct 26, 12:44 PM
Unknown Object (File)
Sat, Oct 26, 2:15 AM
Unknown Object (File)
Sat, Oct 26, 2:15 AM
Unknown Object (File)
Sat, Oct 26, 2:15 AM
Unknown Object (File)
Sat, Oct 26, 2:15 AM
Unknown Object (File)
Sat, Oct 26, 2:15 AM
Unknown Object (File)
Sat, Oct 26, 2:11 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• abosh
varun
Commits
rCOMMf6edc2779ce5: [Android] Update reference to protobuf files
Summary

Update android build to reference new proto location

https://linear.app/comm/issue/ENG-1231

Depends on D4993

Test Plan

Android CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Aug 31 2022, 10:32 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2022, 10:32 AM
• jon added a child revision: D4995: [iOS] Update xcode to point to new proto location.Aug 31 2022, 10:34 AM
• jon edited the summary of this revision. (Show Details)Aug 31 2022, 10:40 AM
• jon added a parent revision: D4993: [Shared/docs] Update `yarn codegen-grpc`.
Harbormaster completed remote builds in B11737: Diff 16128.Aug 31 2022, 10:42 AM
• jon requested review of this revision.Aug 31 2022, 10:42 AM
atul accepted this revision.Aug 31 2022, 8:29 PM
This revision is now accepted and ready to land.Aug 31 2022, 8:29 PM
• jon updated this revision to Diff 16267.Sep 2 2022, 3:25 PM

Update on top of latest master

Harbormaster completed remote builds in B11854: Diff 16267.Sep 2 2022, 3:35 PM
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16418.Sep 7 2022, 9:41 AM

Rebase on master

Harbormaster completed remote builds in B11964: Diff 16418.Sep 7 2022, 9:52 AM
Closed by commit rCOMMf6edc2779ce5: [Android] Update reference to protobuf files (authored by • jon). · Explain WhySep 8 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMf6edc2779ce5: [Android] Update reference to protobuf files.

Revision Contents
Changeset List

PathSize
native/
android/
app/
4 lines

Diff 16507

View Options

native/android/app/CMakeLists.txt

Loading...