Page MenuHomePhabricator
Differential D5119

[Chore] Cleanup tunnelbroker CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:50 PM.
Tags
None
Referenced Files
F3282072: D5119.id16632.diff
Sat, Nov 16, 10:38 AM
Unknown Object (File)
Wed, Nov 13, 1:34 AM
Unknown Object (File)
Sun, Nov 3, 5:40 PM
Unknown Object (File)
Sun, Oct 27, 6:12 AM
Unknown Object (File)
Wed, Oct 23, 3:44 AM
Unknown Object (File)
Oct 11 2024, 2:15 PM
Unknown Object (File)
Oct 9 2024, 3:19 AM
Unknown Object (File)
Oct 9 2024, 3:17 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
• max
• karol
Commits
rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt
Summary

Noticed some dead code from D4671

Test Plan

tunnelbroker CI passes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 1:50 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:50 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:51 PM
Harbormaster failed remote builds in B12094: Diff 16601!
• jon added a parent revision: D5118: [Services] Use BUILD_TESTING for tunnelbroker build.Sep 12 2022, 2:03 PM
• jon updated this revision to Diff 16608.Sep 12 2022, 2:06 PM

Rebase on top of docker fixes

• jon updated this revision to Diff 16611.Sep 12 2022, 2:09 PM

Rebase

Harbormaster completed remote builds in B12101: Diff 16608.Sep 12 2022, 2:16 PM
Harbormaster completed remote builds in B12104: Diff 16611.Sep 12 2022, 2:19 PM
• jon requested review of this revision.Sep 12 2022, 2:19 PM
atul accepted this revision.Sep 13 2022, 9:34 AM

In addition to tunnelbroker CI, was able to run docker-compose build --no-cache tunnelbroker-server successfully on Apple silicon

This revision is now accepted and ready to land.Sep 13 2022, 9:34 AM
Closed by commit rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt (authored by • jon). · Explain WhySep 13 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt.
ashoat added inline comments.Sep 15 2022, 7:04 PM
services/tunnelbroker/CMakeLists.txt
77–81 ↗(On Diff #16632)

I'm a bit confused, what's the point of this line now?

• jon added inline comments.Sep 15 2022, 7:06 PM
services/tunnelbroker/CMakeLists.txt
77–81 ↗(On Diff #16632)

Good point, guess this isn't needed either.

ashoat added inline comments.Sep 16 2022, 8:03 AM
services/tunnelbroker/CMakeLists.txt
77–81 ↗(On Diff #16632)

D5160

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
3 lines

Diff 16601

View Options

services/tunnelbroker/CMakeLists.txt

Loading...