Page MenuHomePhabricator
Differential D5405

[native] [12/34] ReactNav6: use NavHelpers for type parameter name instead of NavProp
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 5:56 PM
Unknown Object (File)
Tue, Nov 26, 5:21 AM
Unknown Object (File)
Mon, Nov 25, 3:40 AM
Unknown Object (File)
Mon, Nov 25, 3:40 AM
Unknown Object (File)
Mon, Nov 25, 3:40 AM
Unknown Object (File)
Nov 15 2024, 5:19 PM
Unknown Object (File)
Nov 15 2024, 2:40 PM
Unknown Object (File)
Nov 15 2024, 2:37 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM07a4b1ccb98a: [native] [12/34] ReactNav6: use NavHelpers for type parameter name instead of…
Summary

Following the changes in the last three diffs, we want to only use NavProp for actual navigation props (corresponding to a specific RouteName), and instead use the name NavHelpers for cases where we can't infer a specific RouteName.

Depends on D5404

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
32 lines
32 lines
32 lines
32 lines
32 lines

Diff 17683

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...