Page MenuHomePhabricator
Differential D5421

[native] [28/34] ReactNav6: Specify headerShown: false for tab bar
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:19 AM.
Tags
None
Referenced Files
F3521709: D5421.id17699.diff
Mon, Dec 23, 4:26 AM
F3520717: D5421.diff
Mon, Dec 23, 1:09 AM
Unknown Object (File)
Wed, Nov 27, 9:07 PM
Unknown Object (File)
Wed, Nov 27, 9:07 PM
Unknown Object (File)
Tue, Nov 26, 5:24 AM
Unknown Object (File)
Mon, Nov 25, 11:47 AM
Unknown Object (File)
Sun, Nov 24, 1:21 AM
Unknown Object (File)
Nov 11 2024, 1:51 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM57e0dd20325f: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar
Summary

Context on change here.

Depends on D5420

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:19 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:19 AM
ashoat added a child revision: D5422: [native] [29/34] ReactNav6: Merge tabBarOptions into options.Oct 20 2022, 6:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:41 AM
Harbormaster failed remote builds in B12908: Diff 17699!
ashoat requested review of this revision.Oct 20 2022, 7:25 AM

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

atul accepted this revision.Oct 20 2022, 12:54 PM
This revision is now accepted and ready to land.Oct 20 2022, 12:54 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:47 PM
Closed by commit rCOMM57e0dd20325f: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM57e0dd20325f: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
1 line
1 line
1 line
1 line
1 line
1 line
navigation/
4 lines

Diff 17699

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...