Page MenuHomePhabricator
Differential D5424

[native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 5:19 PM
Unknown Object (File)
Fri, Dec 27, 5:19 PM
Unknown Object (File)
Fri, Dec 27, 5:17 PM
Unknown Object (File)
Fri, Dec 27, 4:57 PM
Unknown Object (File)
Nov 28 2024, 11:34 PM
Unknown Object (File)
Nov 25 2024, 3:41 AM
Unknown Object (File)
Nov 25 2024, 3:41 AM
Unknown Object (File)
Nov 25 2024, 3:41 AM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMe57d27959985: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options
Summary

Context on change here.

Depends on D5423

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:20 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:20 AM
ashoat added a child revision: D5425: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator.Oct 20 2022, 6:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:44 AM
Harbormaster failed remote builds in B12911: Diff 17702!
ashoat requested review of this revision.Oct 20 2022, 7:25 AM

Build failures are caused by use of @react-navigation/elements in D5420, which isn't introduced until D5427. Sorry!!

atul accepted this revision.Oct 20 2022, 12:58 PM
This revision is now accepted and ready to land.Oct 20 2022, 12:58 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:48 PM
Closed by commit rCOMMe57d27959985: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe57d27959985: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options.

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
navigation/
2 lines

Diff 17702

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...