Differential D5405 Authored by ashoat on Oct 20 2022, 1:13 PM.
Details Summary Following the changes in the last three diffs, we want to only use NavProp for actual navigation props (corresponding to a specific RouteName), and instead use the name NavHelpers for cases where we can't infer a specific RouteName. Depends on D5404 Test Plan Flow + ran the app on my phone and played around with it
Diff Detail
Event TimelineHerald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 1:13 PM2022-10-20 13:13:40 (UTC+0) Harbormaster completed remote builds in B12892: Diff 17683.Oct 20 2022, 1:41 PM2022-10-20 13:41:02 (UTC+0) This revision is now accepted and ready to land.Oct 20 2022, 6:27 PM2022-10-20 18:27:14 (UTC+0) Closed by commit rCOMM07a4b1ccb98a: [native] [12/34] ReactNav6: use NavHelpers for type parameter name instead of…. · Explain WhyOct 20 2022, 8:47 PM2022-10-20 20:47:27 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 17768 |