Page MenuHomePhabricator
Differential D5405

[native] [12/34] ReactNav6: use NavHelpers for type parameter name instead of NavProp
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:13 AM.
Tags
None
Referenced Files
F3249433: D5405.id17683.diff
Fri, Nov 15, 2:40 PM
F3249427: D5405.id17768.diff
Fri, Nov 15, 2:37 PM
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Oct 7 2024, 5:31 PM
Unknown Object (File)
Sep 26 2024, 7:08 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMM07a4b1ccb98a: [native] [12/34] ReactNav6: use NavHelpers for type parameter name instead of…
Summary

Following the changes in the last three diffs, we want to only use NavProp for actual navigation props (corresponding to a specific RouteName), and instead use the name NavHelpers for cases where we can't infer a specific RouteName.

Depends on D5404

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
@react-navigation/
32 lines
32 lines
32 lines
32 lines
32 lines

Diff 17768

View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...