Page MenuHomePhabricator

[services] Get rid of `return std::move(...)` in services codebase
ClosedPublic

Authored by atul on Nov 10 2022, 2:03 PM.
Tags
None
Referenced Files
F3523472: D5608.id18381.diff
Mon, Dec 23, 9:28 AM
F3523056: D5608.id18357.diff
Mon, Dec 23, 8:15 AM
F3521788: D5608.diff
Mon, Dec 23, 4:51 AM
Unknown Object (File)
Nov 2 2024, 10:15 PM
Unknown Object (File)
Nov 2 2024, 10:15 PM
Unknown Object (File)
Nov 2 2024, 10:15 PM
Unknown Object (File)
Nov 2 2024, 10:12 PM
Unknown Object (File)
Oct 6 2024, 2:42 PM
Subscribers

Details

Summary

Context: https://linear.app/comm/issue/ENG-619/get-rid-of-stdmove-in-the-services-codebase

https://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c
https://phabricator.ashoat.com/D2912?id=8614#inline-15820
https://phabricator.ashoat.com/D2876?id=8631#inline-15961

NOTE: We don't want to remove std::move altogether, just when we're returning so we don't interfere with return value optimization. We're still going to need to std::move unique_ptrs into lambdas and whatnot.
Test Plan

CI and close reading and previous discussion

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable