Page MenuHomePhabricator

[native] Render second TextMessage with all Texts pressable when markdownHasPressable
ClosedPublic

Authored by ashoat on Nov 29 2022, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 8:52 AM
Unknown Object (File)
Nov 23 2024, 12:51 PM
Unknown Object (File)
Nov 8 2024, 4:16 PM
Unknown Object (File)
Nov 8 2024, 4:16 PM
Unknown Object (File)
Nov 8 2024, 4:08 PM
Unknown Object (File)
Nov 8 2024, 3:59 PM
Unknown Object (File)
Nov 4 2024, 3:10 AM
Unknown Object (File)
Nov 4 2024, 3:10 AM
Subscribers

Details

Summary

This is a potential solution to the issues we have with Markdown pressables.

Test Plan

I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

The comment for secondMessage makes sense, locally I didn't see any issues with the secondMessage being rendered with both existing and new messages being sent.

This revision is now accepted and ready to land.Nov 30 2022, 9:40 AM

Follow up question, is this message press experience the one we want to keep going forward?

Before when pressing on a message outside the text:

Screenshot 2022-11-30 at 1.55.30 PM.png (1×803 px, 335 KB)

Now:

Screenshot 2022-11-30 at 1.56.09 PM.png (1×798 px, 342 KB)

Follow up question, is this message press experience the one we want to keep going forward?

Before when pressing on a message outside the text:

That's the downside of this approach, and that's why we're only doing it for pressables. It's definitely worse